Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1167613003: Add a runtime data dependency on icudtl.dat in the GN build. (Closed)

Created:
5 years, 6 months ago by Dirk Pranke
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a runtime data dependency on icudtl.dat in the GN build. This allows targets that use GN to correctly note that they need the .dat file to be included in .isolates. R=brettw@chromium.org, jshin@chromium.org BUG= Committed: https://chromium.googlesource.com/chromium/deps/icu/+/45a095d561334871dd8673cf8e5cca330d33f521

Patch Set 1 #

Total comments: 2

Patch Set 2 : add data dll on win build also #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M BUILD.gn View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dirk Pranke
5 years, 6 months ago (2015-06-03 23:17:39 UTC) #1
brettw
lgtm
5 years, 6 months ago (2015-06-04 04:37:30 UTC) #2
brettw
https://codereview.chromium.org/1167613003/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1167613003/diff/1/BUILD.gn#newcode542 BUILD.gn:542: copy("icudata") { Might also need to mark this dll ...
5 years, 6 months ago (2015-06-04 04:38:30 UTC) #3
Dirk Pranke
https://codereview.chromium.org/1167613003/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1167613003/diff/1/BUILD.gn#newcode542 BUILD.gn:542: copy("icudata") { On 2015/06/04 04:38:30, brettw wrote: > Might ...
5 years, 6 months ago (2015-06-04 20:32:25 UTC) #4
Dirk Pranke
Updated; still lgty?
5 years, 6 months ago (2015-06-09 02:06:16 UTC) #5
brettw
Yes, still lgtm
5 years, 6 months ago (2015-06-09 15:34:40 UTC) #6
Dirk Pranke
5 years, 6 months ago (2015-06-09 19:35:44 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
45a095d561334871dd8673cf8e5cca330d33f521 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698