Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: BUILD.gn

Issue 1167613003: Add a runtime data dependency on icudtl.dat in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/icu/config.gni") 5 import("//third_party/icu/config.gni")
6 6
7 # Meta target that includes both icuuc and icui18n. Most targets want both. 7 # Meta target that includes both icuuc and icui18n. Most targets want both.
8 # You can depend on the individually if you need to. 8 # You can depend on the individually if you need to.
9 group("icu") { 9 group("icu") {
10 deps = [ 10 deps = [
(...skipping 512 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 ] 523 ]
524 } else { 524 } else {
525 sources = [ 525 sources = [
526 "source/data/in/icudtl.dat", 526 "source/data/in/icudtl.dat",
527 ] 527 ]
528 } 528 }
529 529
530 outputs = [ 530 outputs = [
531 "$root_out_dir/icudtl.dat", 531 "$root_out_dir/icudtl.dat",
532 ] 532 ]
533
534 data = [
535 "$root_out_dir/icudtl.dat",
536 ]
533 } 537 }
534 } 538 }
535 } else { 539 } else {
536 if (is_win) { 540 if (is_win) {
537 # On Windows the target DLL is pre-built so just use a copy rule. 541 # On Windows the target DLL is pre-built so just use a copy rule.
538 copy("icudata") { 542 copy("icudata") {
brettw 2015/06/04 04:38:30 Might also need to mark this dll on Windows.
Dirk Pranke 2015/06/04 20:32:25 ack.
539 sources = [ 543 sources = [
540 "windows/icudt.dll", 544 "windows/icudt.dll",
541 ] 545 ]
542 outputs = [ 546 outputs = [
543 "$root_out_dir/icudt.dll", 547 "$root_out_dir/icudt.dll",
544 ] 548 ]
545 } 549 }
546 } else { 550 } else {
547 source_set("icudata") { 551 source_set("icudata") {
548 # These are hand-generated, but will do for now. 552 # These are hand-generated, but will do for now.
(...skipping 12 matching lines...) Expand all
561 sources = [ 565 sources = [
562 "android/icudtl_dat.S", 566 "android/icudtl_dat.S",
563 ] 567 ]
564 } else { 568 } else {
565 assert(false, "No icu data for this platform") 569 assert(false, "No icu data for this platform")
566 } 570 }
567 defines = [ "U_HIDE_DATA_SYMBOL" ] 571 defines = [ "U_HIDE_DATA_SYMBOL" ]
568 } 572 }
569 } 573 }
570 } 574 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698