Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: BUILD.gn

Issue 1167613003: Add a runtime data dependency on icudtl.dat in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: add data dll on win build also Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/icu/config.gni") 5 import("//third_party/icu/config.gni")
6 6
7 # Meta target that includes both icuuc and icui18n. Most targets want both. 7 # Meta target that includes both icuuc and icui18n. Most targets want both.
8 # You can depend on the individually if you need to. 8 # You can depend on the individually if you need to.
9 group("icu") { 9 group("icu") {
10 deps = [ 10 deps = [
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 ] 510 ]
511 } else { 511 } else {
512 sources = [ 512 sources = [
513 "source/data/in/icudtl.dat", 513 "source/data/in/icudtl.dat",
514 ] 514 ]
515 } 515 }
516 516
517 outputs = [ 517 outputs = [
518 "$root_out_dir/icudtl.dat", 518 "$root_out_dir/icudtl.dat",
519 ] 519 ]
520
521 data = [
522 "$root_out_dir/icudtl.dat",
523 ]
520 } 524 }
521 } 525 }
522 } else { 526 } else {
523 if (is_win) { 527 if (is_win) {
524 # On Windows the target DLL is pre-built so just use a copy rule. 528 # On Windows the target DLL is pre-built so just use a copy rule.
525 copy("icudata") { 529 copy("icudata") {
526 sources = [ 530 sources = [
527 "windows/icudt.dll", 531 "windows/icudt.dll",
528 ] 532 ]
529 outputs = [ 533 outputs = [
530 "$root_out_dir/icudt.dll", 534 "$root_out_dir/icudt.dll",
531 ] 535 ]
536
537 data = [
538 "$root_out_dir/icudtl.dll",
539 ]
532 } 540 }
533 } else { 541 } else {
534 source_set("icudata") { 542 source_set("icudata") {
535 # These are hand-generated, but will do for now. 543 # These are hand-generated, but will do for now.
536 # 544 #
537 # TODO(GYP): Gyp has considerations here for QNX and for the host toolchai n 545 # TODO(GYP): Gyp has considerations here for QNX and for the host toolchai n
538 # that have not been ported over. 546 # that have not been ported over.
539 if (is_linux) { 547 if (is_linux) {
540 sources = [ 548 sources = [
541 "linux/icudtl_dat.S", 549 "linux/icudtl_dat.S",
542 ] 550 ]
543 } else if (is_mac) { 551 } else if (is_mac) {
544 sources = [ 552 sources = [
545 "mac/icudtl_dat.S", 553 "mac/icudtl_dat.S",
546 ] 554 ]
547 } else if (is_android) { 555 } else if (is_android) {
548 sources = [ 556 sources = [
549 "android/icudtl_dat.S", 557 "android/icudtl_dat.S",
550 ] 558 ]
551 } else { 559 } else {
552 assert(false, "No icu data for this platform") 560 assert(false, "No icu data for this platform")
553 } 561 }
554 defines = [ "U_HIDE_DATA_SYMBOL" ] 562 defines = [ "U_HIDE_DATA_SYMBOL" ]
555 } 563 }
556 } 564 }
557 } 565 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698