Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: BUILD.gn

Issue 1167613003: Add a runtime data dependency on icudtl.dat in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: add data dll on win build also Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 351fbb10a0bb413e241e1344b4fef46538927d83..5b8c0b1470552e0f3e9133e1a707680665a3e491 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -517,6 +517,10 @@ if (icu_use_data_file) {
outputs = [
"$root_out_dir/icudtl.dat",
]
+
+ data = [
+ "$root_out_dir/icudtl.dat",
+ ]
}
}
} else {
@@ -529,6 +533,10 @@ if (icu_use_data_file) {
outputs = [
"$root_out_dir/icudt.dll",
]
+
+ data = [
+ "$root_out_dir/icudtl.dll",
+ ]
}
} else {
source_set("icudata") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698