Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1167123002: Check Member<T> validity for stack allocated objects. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check Member<T> validity for stack allocated objects. For Member<T> in a stack allocated object, make the Blink GC plugin verify that T is a GC allocated object. R=haraken BUG=495398 Committed: https://crrev.com/b95bbfb9b48f40a15e0ba051a41b6250dfd33698 Cr-Commit-Position: refs/heads/master@{#333217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 6 chunks +26 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/member_in_offheap_class.txt View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look.
5 years, 6 months ago (2015-06-06 08:54:01 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-06-06 10:29:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167123002/1
5 years, 6 months ago (2015-06-06 18:08:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-06 18:19:31 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 18:20:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b95bbfb9b48f40a15e0ba051a41b6250dfd33698
Cr-Commit-Position: refs/heads/master@{#333217}

Powered by Google App Engine
This is Rietveld 408576698