Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h

Issue 1167123002: Check Member<T> validity for stack allocated objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEMBER_IN_OFFHEAP_CLASS_H_ 5 #ifndef MEMBER_IN_OFFHEAP_CLASS_H_
6 #define MEMBER_IN_OFFHEAP_CLASS_H_ 6 #define MEMBER_IN_OFFHEAP_CLASS_H_
7 7
8 #include "heap/stubs.h" 8 #include "heap/stubs.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 class HeapObject : public GarbageCollected<HeapObject> { }; 12 class HeapObject : public GarbageCollected<HeapObject> { };
13 13
14 class OffHeapObject { 14 class OffHeapObject {
15 public: 15 public:
16 void trace(Visitor*); 16 void trace(Visitor*);
17 private: 17 private:
18 Member<HeapObject> m_obj; // Must not contain Member. 18 Member<HeapObject> m_obj; // Must not contain Member.
19 Persistent<HeapVector<Member<HeapObject> > > m_objs; // OK 19 Persistent<HeapVector<Member<HeapObject> > > m_objs; // OK
20 }; 20 };
21 21
22 class StackObject { 22 class StackObject {
23 STACK_ALLOCATED(); 23 STACK_ALLOCATED();
24 private: 24 private:
25 Member<HeapObject> m_obj; // OK 25 Member<HeapObject> m_obj; // OK
26 Member<OffHeapObject> m_memberOff; // NOT OK
27 HeapVector<Member<OffHeapObject>> m_heapVectorMemberOff; // NOT OK
26 }; 28 };
27 29
28 class PartObject { 30 class PartObject {
29 DISALLOW_ALLOCATION(); 31 DISALLOW_ALLOCATION();
30 public: 32 public:
31 void trace(Visitor*); 33 void trace(Visitor*);
32 private: 34 private:
33 Member<HeapObject> m_obj; // OK 35 Member<HeapObject> m_obj; // OK
34 }; 36 };
35 37
36 class InlineObject { 38 class InlineObject {
37 ALLOW_ONLY_INLINE_ALLOCATION(); 39 ALLOW_ONLY_INLINE_ALLOCATION();
38 public: 40 public:
39 void trace(Visitor*); 41 void trace(Visitor*);
40 private: 42 private:
41 Member<HeapObject> m_obj; // OK 43 Member<HeapObject> m_obj; // OK
42 }; 44 };
43 45
44 } 46 }
45 47
46 #endif 48 #endif
OLDNEW
« no previous file with comments | « tools/clang/blink_gc_plugin/RecordInfo.cpp ('k') | tools/clang/blink_gc_plugin/tests/member_in_offheap_class.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698