tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h - Issue 1167123002: Check Member<T> validity for stack allocated objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h

Issue 1167123002: Check Member<T> validity for stack allocated objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h

diff --git a/tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h b/tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h

index 0dcacc559d4f4cc2f1927d696746c39e8f866056..5a59c7e8eb25f4d724cb2fb323f38f265791e45d 100644

--- a/tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h

+++ b/tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h

@@ -23,6 +23,8 @@ class StackObject {

STACK_ALLOCATED();

private:

Member<HeapObject> m_obj; // OK

+ Member<OffHeapObject> m_memberOff; // NOT OK

+ HeapVector<Member<OffHeapObject>> m_heapVectorMemberOff; // NOT OK

};

class PartObject {

« no previous file with comments | « tools/clang/blink_gc_plugin/RecordInfo.cpp ('k') | tools/clang/blink_gc_plugin/tests/member_in_offheap_class.txt » ('j') | no next file with comments »