tools/clang/blink_gc_plugin/tests/member_in_offheap_class.txt - Issue 1167123002: Check Member<T> validity for stack allocated objects.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/member_in_offheap_class.txt

Issue 1167123002: Check Member<T> validity for stack allocated objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 In file included from member_in_offheap_class.cpp:5:	1 In file included from member_in_offheap_class.cpp:5:

2 ./member_in_offheap_class.h:14:1: warning: [blink-gc] Class 'OffHeapObject' cont ains invalid fields.	2 ./member_in_offheap_class.h:14:1: warning: [blink-gc] Class 'OffHeapObject' cont ains invalid fields.

3 class OffHeapObject {	3 class OffHeapObject {

4 ^	4 ^

5 ./member_in_offheap_class.h:18:5: note: [blink-gc] Member field 'm_obj' in unman aged class declared here:	5 ./member_in_offheap_class.h:18:5: note: [blink-gc] Member field 'm_obj' in unman aged class declared here:

6 Member<HeapObject> m_obj; // Must not contain Member.	6 Member<HeapObject> m_obj; // Must not contain Member.

7 ^	7 ^

8 1 warning generated.	8 ./member_in_offheap_class.h:22:1: warning: [blink-gc] Class 'StackObject' contai ns invalid fields.

	9 class StackObject {

	10 ^

	11 ./member_in_offheap_class.h:26:5: note: [blink-gc] Member field 'm_memberOff' to non-GC managed class declared here:

	12 Member<OffHeapObject> m_memberOff; // NOT OK

	13 ^

	14 ./member_in_offheap_class.h:27:5: note: [blink-gc] Member field 'm_heapVectorMem berOff' to non-GC managed class declared here:

	15 HeapVector<Member<OffHeapObject>> m_heapVectorMemberOff; // NOT OK

	16 ^

	17 2 warnings generated.

OLD	NEW

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/member_in_offheap_class.h ('k') | no next file » | no next file with comments »