Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1166763002: Reland "Mandoline filesystem: Build the filesystem on windows." (Closed)

Created:
5 years, 6 months ago by Elliot Glaysher
Modified:
5 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Mandoline filesystem: Build the filesystem on windows." This adds a cast which gcc didn't need, but msvc-64 wants. This condition is checked for overflow at the top of the method. BUG=490237 First Review URL: https://codereview.chromium.org/1163713002 TBR=sky@chromium.org Committed: https://crrev.com/655f1b18105cb2afe0ba166a75da1477d2194661 Cr-Commit-Position: refs/heads/master@{#332436}

Patch Set 1 #

Patch Set 2 : DWORD -> INT for real checking. (This was wrong.) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -290 lines) Patch
M components/filesystem/directory_impl.cc View 5 chunks +21 lines, -19 lines 0 comments Download
M components/filesystem/directory_impl_unittest.cc View 3 chunks +31 lines, -31 lines 0 comments Download
M components/filesystem/file_impl.cc View 1 15 chunks +38 lines, -32 lines 0 comments Download
M components/filesystem/file_impl_unittest.cc View 18 chunks +129 lines, -129 lines 0 comments Download
M components/filesystem/file_system_impl.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M components/filesystem/files_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/filesystem/public/interfaces/directory.mojom View 2 chunks +5 lines, -5 lines 0 comments Download
M components/filesystem/public/interfaces/file.mojom View 2 chunks +10 lines, -10 lines 0 comments Download
M components/filesystem/public/interfaces/file_system.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/interfaces/types.mojom View 4 chunks +7 lines, -4 lines 0 comments Download
M components/filesystem/util.h View 1 chunk +7 lines, -7 lines 0 comments Download
M components/filesystem/util.cc View 4 chunks +43 lines, -33 lines 0 comments Download
M mandoline/BUILD.gn View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Elliot Glaysher
tbring two line windows 64 specific compile change to already reviewed code.
5 years, 6 months ago (2015-06-02 17:56:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166763002/20001
5 years, 6 months ago (2015-06-02 17:57:52 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-02 18:41:29 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 18:43:28 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/655f1b18105cb2afe0ba166a75da1477d2194661
Cr-Commit-Position: refs/heads/master@{#332436}

Powered by Google App Engine
This is Rietveld 408576698