Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/filesystem/public/interfaces/directory.mojom

Issue 1166763002: Reland "Mandoline filesystem: Build the filesystem on windows." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DWORD -> INT for real checking. (This was wrong.) Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/filesystem/files_test_base.cc ('k') | components/filesystem/public/interfaces/file.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/filesystem/public/interfaces/directory.mojom
diff --git a/components/filesystem/public/interfaces/directory.mojom b/components/filesystem/public/interfaces/directory.mojom
index 04c0bc0b9406d6bc299a353b5b8699b38aeeedad..5d3a1db4a1c89d311808621b45fb8678f75eec1d 100644
--- a/components/filesystem/public/interfaces/directory.mojom
+++ b/components/filesystem/public/interfaces/directory.mojom
@@ -19,7 +19,7 @@ interface Directory {
// Reads the contents of this directory.
// TODO(vtl): Clarify error codes versus |directory_contents|.
- Read() => (Error error, array<DirectoryEntry>? directory_contents);
+ Read() => (FileError error, array<DirectoryEntry>? directory_contents);
// Operations *in* "this" |Directory|:
@@ -27,20 +27,20 @@ interface Directory {
// optional, mainly for consistency with |OpenDirectory()| (but may be useful,
// together with |kOpenFlagCreate|, for "touching" a file).
OpenFile(string path, File&? file, uint32 open_flags)
- => (Error error);
+ => (FileError error);
// Opens the directory specified by |path|. |directory| is optional, so that
// this may be used as a simple "mkdir()" with |kOpenFlagCreate|.
OpenDirectory(string path,
Directory&? directory,
- uint32 open_flags) => (Error error);
+ uint32 open_flags) => (FileError error);
// Renames/moves the file/directory given by |path| to |new_path|.
- Rename(string path, string new_path) => (Error error);
+ Rename(string path, string new_path) => (FileError error);
// Deletes the given path, which may be a file or a directory (see
// |kDeleteFlag...| for details).
- Delete(string path, uint32 delete_flags) => (Error error);
+ Delete(string path, uint32 delete_flags) => (FileError error);
// TODO(vtl): directory "streaming"?
// TODO(vtl): "make root" (i.e., prevent cd-ing, etc., to parent); note that
« no previous file with comments | « components/filesystem/files_test_base.cc ('k') | components/filesystem/public/interfaces/file.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698