Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: components/filesystem/util.h

Issue 1166763002: Reland "Mandoline filesystem: Build the filesystem on windows." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DWORD -> INT for real checking. (This was wrong.) Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/filesystem/public/interfaces/types.mojom ('k') | components/filesystem/util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/filesystem/util.h
diff --git a/components/filesystem/util.h b/components/filesystem/util.h
index 7ce60c47a31a76f73a41cb1a638aef584cf0e106..0a3042bedcde8355827755c1101bf0888fde38ac 100644
--- a/components/filesystem/util.h
+++ b/components/filesystem/util.h
@@ -21,30 +21,30 @@ namespace filesystem {
// Checks if |path|, which must be non-null, is (looks like) a valid (relative)
// path. (On failure, returns |ERROR_INVALID_ARGUMENT| if |path| is not UTF-8,
// or |ERROR_PERMISSION_DENIED| if it is not relative.)
-Error IsPathValid(const mojo::String& path);
+FileError IsPathValid(const mojo::String& path);
// Checks if |whence| is a valid (known) |Whence| value. (On failure, returns
// |ERROR_UNIMPLEMENTED|.)
-Error IsWhenceValid(Whence whence);
+FileError IsWhenceValid(Whence whence);
// Checks if |offset| is a valid file offset (from some point); this is
// implementation-dependent (typically checking if |offset| fits in an |off_t|).
// (On failure, returns |ERROR_OUT_OF_RANGE|.)
-Error IsOffsetValid(int64_t offset);
+FileError IsOffsetValid(int64_t offset);
// Conversion functions:
// Returns the platform dependent error details converted to the
// filesystem.Error enum.
-Error GetError(const base::File& file);
+FileError GetError(const base::File& file);
// Serializes Info to the wire format.
FileInformationPtr MakeFileInformation(const base::File::Info& info);
// Creates an absolute file path and ensures that we don't try to traverse up.
-Error ValidatePath(const mojo::String& raw_path,
- const base::FilePath& filesystem_base,
- base::FilePath* out);
+FileError ValidatePath(const mojo::String& raw_path,
+ const base::FilePath& filesystem_base,
+ base::FilePath* out);
} // namespace filesystem
« no previous file with comments | « components/filesystem/public/interfaces/types.mojom ('k') | components/filesystem/util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698