Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1163713002: Mandoline filesystem: Enable windows build. (Closed)

Created:
5 years, 6 months ago by Elliot Glaysher
Modified:
5 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mandoline filesystem: Build the filesystem on windows. This resolves name collisions with #defines in windows.h and does os specific path handling in a few places. BUG=490237 Committed: https://crrev.com/3e8be89d1827aed47a9deeb7d1b6745258c17000 Cr-Commit-Position: refs/heads/master@{#332073}

Patch Set 1 #

Patch Set 2 : Rename Error -> FileError. #

Patch Set 3 : Rename FileType to FsFileType. #

Patch Set 4 : Fix limits? #

Patch Set 5 : Hopefully the last two errors. #

Patch Set 6 : Maybe fix string conversion. #

Patch Set 7 : namespace? #

Patch Set 8 : Add '.get()' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -289 lines) Patch
M components/filesystem/directory_impl.cc View 1 2 5 chunks +21 lines, -19 lines 0 comments Download
M components/filesystem/directory_impl_unittest.cc View 1 2 3 chunks +31 lines, -31 lines 0 comments Download
M components/filesystem/file_impl.cc View 1 2 3 16 chunks +36 lines, -31 lines 0 comments Download
M components/filesystem/file_impl_unittest.cc View 1 2 18 chunks +129 lines, -129 lines 0 comments Download
M components/filesystem/file_system_impl.cc View 1 2 3 4 2 chunks +2 lines, -8 lines 0 comments Download
M components/filesystem/files_test_base.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/filesystem/public/interfaces/directory.mojom View 1 2 chunks +5 lines, -5 lines 0 comments Download
M components/filesystem/public/interfaces/file.mojom View 1 2 chunks +10 lines, -10 lines 0 comments Download
M components/filesystem/public/interfaces/file_system.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/interfaces/types.mojom View 1 2 4 chunks +7 lines, -4 lines 0 comments Download
M components/filesystem/util.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M components/filesystem/util.cc View 1 2 3 4 5 6 7 4 chunks +43 lines, -33 lines 0 comments Download
M mandoline/BUILD.gn View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Elliot Glaysher
5 years, 6 months ago (2015-05-29 22:18:20 UTC) #2
sky
LGTM
5 years, 6 months ago (2015-05-29 22:47:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163713002/140001
5 years, 6 months ago (2015-05-29 22:52:15 UTC) #5
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 6 months ago (2015-05-29 23:12:54 UTC) #6
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/3e8be89d1827aed47a9deeb7d1b6745258c17000 Cr-Commit-Position: refs/heads/master@{#332073}
5 years, 6 months ago (2015-05-29 23:13:48 UTC) #7
Elliot Glaysher
5 years, 6 months ago (2015-05-29 23:27:54 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1163523006/ by erg@chromium.org.

The reason for reverting is: Patch failed on Win 8 GN:

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo
/showIncludes /FC
@obj/components/filesystem/filesystem_library.file_impl.obj.rsp /c
../../components/filesystem/file_impl.cc
/Foobj/components/filesystem/filesystem_library.file_impl.obj
/Fdobj/components/filesystem/filesystem_library_cc.pdb
e:\b\build\slave\win_x64_gn\build\src\components\filesystem\file_impl.cc(129) :
error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_x64_gn\build\src\components\filesystem\file_impl.cc(129) :
warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of
data
.

Powered by Google App Engine
This is Rietveld 408576698