Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 116543010: Remove the Value class names from the global namespace. (Closed)

Created:
7 years ago by Avi (use Gerrit)
Modified:
6 years, 12 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Remove the Value class names from the global namespace. BUG=88666 TEST=no change TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242440

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : fixes #

Patch Set 4 : once more #

Patch Set 5 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -392 lines) Patch
M base/prefs/scoped_user_pref_update.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/scoped_user_pref_update_unittest.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M base/values.h View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/extensions/external_pref_loader.cc View 1 2 3 4 5 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/prefs/pref_hash_calculator.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_hash_calculator_unittest.cc View 1 2 3 4 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/prefs/pref_hash_store_impl.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_hash_store_impl_unittest.cc View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/v8_value_converter_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/event_router.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/event_router_unittest.cc View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
M sync/internal_api/public/change_record_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/additional_properties_unittest.cc View 1 2 3 4 4 chunks +11 lines, -10 lines 0 comments Download
M tools/json_schema_compiler/test/any_unittest.cc View 1 2 3 4 2 chunks +11 lines, -9 lines 0 comments Download
M tools/json_schema_compiler/test/arrays_unittest.cc View 1 2 3 4 13 chunks +58 lines, -56 lines 0 comments Download
M tools/json_schema_compiler/test/callbacks_unittest.cc View 1 2 3 4 2 chunks +8 lines, -7 lines 0 comments Download
M tools/json_schema_compiler/test/choices_unittest.cc View 1 2 3 4 4 chunks +23 lines, -23 lines 0 comments Download
M tools/json_schema_compiler/test/crossref_unittest.cc View 1 2 3 4 6 chunks +35 lines, -26 lines 0 comments Download
M tools/json_schema_compiler/test/enums_unittest.cc View 1 2 3 4 14 chunks +62 lines, -60 lines 0 comments Download
M tools/json_schema_compiler/test/error_generation_unittest.cc View 1 2 3 4 9 chunks +17 lines, -17 lines 0 comments Download
M tools/json_schema_compiler/test/functions_as_parameters_unittest.cc View 1 2 3 4 5 chunks +16 lines, -16 lines 0 comments Download
M tools/json_schema_compiler/test/functions_on_types_unittest.cc View 1 2 3 4 3 chunks +13 lines, -11 lines 0 comments Download
M tools/json_schema_compiler/test/idl_schemas_unittest.cc View 1 2 3 4 10 chunks +28 lines, -28 lines 0 comments Download
M tools/json_schema_compiler/test/objects_unittest.cc View 1 2 3 4 4 chunks +19 lines, -19 lines 0 comments Download
M tools/json_schema_compiler/test/simple_api_unittest.cc View 1 2 3 4 11 chunks +47 lines, -41 lines 0 comments Download
M tools/json_schema_compiler/util.h View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/util.cc View 1 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/116543010/70001
7 years ago (2013-12-24 00:37:53 UTC) #1
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=206148
7 years ago (2013-12-24 01:02:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/116543010/360001
7 years ago (2013-12-24 01:05:47 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=206155
7 years ago (2013-12-24 01:29:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/116543010/460002
7 years ago (2013-12-24 03:14:52 UTC) #5
commit-bot: I haz the power
6 years, 12 months ago (2013-12-24 15:31:26 UTC) #6
Message was sent while issue was closed.
Change committed as 242440

Powered by Google App Engine
This is Rietveld 408576698