Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: base/prefs/scoped_user_pref_update_unittest.cc

Issue 116543010: Remove the Value class names from the global namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/prefs/scoped_user_pref_update.cc ('k') | base/values.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/scoped_user_pref_update_unittest.cc
diff --git a/base/prefs/scoped_user_pref_update_unittest.cc b/base/prefs/scoped_user_pref_update_unittest.cc
index 505526c07cf0087ceee76e7f2f22c9f1f7bb58a8..dfe2074720d93fca0fa9da6ac7f60e04fba215fc 100644
--- a/base/prefs/scoped_user_pref_update_unittest.cc
+++ b/base/prefs/scoped_user_pref_update_unittest.cc
@@ -40,13 +40,13 @@ const char ScopedUserPrefUpdateTest::kValue[] = "value";
TEST_F(ScopedUserPrefUpdateTest, RegularUse) {
// Dictionary that will be expected to be set at the end.
- DictionaryValue expected_dictionary;
+ base::DictionaryValue expected_dictionary;
expected_dictionary.SetString(kKey, kValue);
{
EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0);
DictionaryPrefUpdate update(&prefs_, kPref);
- DictionaryValue* value = update.Get();
+ base::DictionaryValue* value = update.Get();
ASSERT_TRUE(value);
value->SetString(kKey, kValue);
@@ -55,7 +55,7 @@ TEST_F(ScopedUserPrefUpdateTest, RegularUse) {
Mock::VerifyAndClearExpectations(&observer_);
// Modifications happen online and are instantly visible, though.
- const DictionaryValue* current_value = prefs_.GetDictionary(kPref);
+ const base::DictionaryValue* current_value = prefs_.GetDictionary(kPref);
ASSERT_TRUE(current_value);
EXPECT_TRUE(expected_dictionary.Equals(current_value));
@@ -64,18 +64,18 @@ TEST_F(ScopedUserPrefUpdateTest, RegularUse) {
}
Mock::VerifyAndClearExpectations(&observer_);
- const DictionaryValue* current_value = prefs_.GetDictionary(kPref);
+ const base::DictionaryValue* current_value = prefs_.GetDictionary(kPref);
ASSERT_TRUE(current_value);
EXPECT_TRUE(expected_dictionary.Equals(current_value));
}
TEST_F(ScopedUserPrefUpdateTest, NeverTouchAnything) {
- const DictionaryValue* old_value = prefs_.GetDictionary(kPref);
+ const base::DictionaryValue* old_value = prefs_.GetDictionary(kPref);
EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0);
{
DictionaryPrefUpdate update(&prefs_, kPref);
}
- const DictionaryValue* new_value = prefs_.GetDictionary(kPref);
+ const base::DictionaryValue* new_value = prefs_.GetDictionary(kPref);
EXPECT_EQ(old_value, new_value);
Mock::VerifyAndClearExpectations(&observer_);
}
« no previous file with comments | « base/prefs/scoped_user_pref_update.cc ('k') | base/values.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698