Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: extensions/browser/event_router_unittest.cc

Issue 116543010: Remove the Value class names from the global namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/event_router.cc ('k') | sync/internal_api/public/change_record_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/event_router_unittest.cc
diff --git a/extensions/browser/event_router_unittest.cc b/extensions/browser/event_router_unittest.cc
index ba5fed300deb929cd0a12e88d12f86db47d01868..c47b7f20eddcee16cdd382e476cfefd5898118f1 100644
--- a/extensions/browser/event_router_unittest.cc
+++ b/extensions/browser/event_router_unittest.cc
@@ -69,7 +69,7 @@ TEST_F(EventRouterTest, GetBaseEventName) {
TEST_F(EventRouterTest, EventRouterObserver) {
EventRouter router(NULL, NULL);
EventListener listener(
- "event_name", "extension_id", NULL, scoped_ptr<DictionaryValue>());
+ "event_name", "extension_id", NULL, scoped_ptr<base::DictionaryValue>());
// Add/remove works without any observers.
router.OnListenerAdded(&listener);
@@ -104,8 +104,10 @@ TEST_F(EventRouterTest, EventRouterObserver) {
// Adding a listener with a sub-event notifies the main observer with
// proper details.
matching_observer.Reset();
- EventListener sub_event_listener(
- "event_name/1", "extension_id", NULL, scoped_ptr<DictionaryValue>());
+ EventListener sub_event_listener("event_name/1",
+ "extension_id",
+ NULL,
+ scoped_ptr<base::DictionaryValue>());
router.OnListenerAdded(&sub_event_listener);
EXPECT_EQ(1, matching_observer.listener_added_count());
EXPECT_EQ(0, matching_observer.listener_removed_count());
« no previous file with comments | « extensions/browser/event_router.cc ('k') | sync/internal_api/public/change_record_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698