Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: tools/json_schema_compiler/test/callbacks_unittest.cc

Issue 116543010: Remove the Value class names from the global namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/callbacks_unittest.cc
diff --git a/tools/json_schema_compiler/test/callbacks_unittest.cc b/tools/json_schema_compiler/test/callbacks_unittest.cc
index 163a6c0e3cdc2f1e9dbfff9c427159e75697acc9..e69289eb522fcdd39c962bc2f4280f57e6382bc1 100644
--- a/tools/json_schema_compiler/test/callbacks_unittest.cc
+++ b/tools/json_schema_compiler/test/callbacks_unittest.cc
@@ -11,11 +11,12 @@ using namespace test::api::callbacks;
TEST(JsonSchemaCompilerCallbacksTest, ReturnsObjectResultCreate) {
ReturnsObject::Results::SomeObject some_object;
some_object.state = ReturnsObject::Results::SomeObject::STATE_FOO;
- scoped_ptr<ListValue> results = ReturnsObject::Results::Create(some_object);
+ scoped_ptr<base::ListValue> results =
+ ReturnsObject::Results::Create(some_object);
- DictionaryValue* expected_dict = new DictionaryValue();
+ base::DictionaryValue* expected_dict = new base::DictionaryValue();
expected_dict->SetString("state", "foo");
- ListValue expected;
+ base::ListValue expected;
expected.Append(expected_dict);
EXPECT_TRUE(results->Equals(&expected));
}
@@ -23,13 +24,13 @@ TEST(JsonSchemaCompilerCallbacksTest, ReturnsObjectResultCreate) {
TEST(JsonSchemaCompilerCallbacksTest, ReturnsMultipleResultCreate) {
ReturnsMultiple::Results::SomeObject some_object;
some_object.state = ReturnsMultiple::Results::SomeObject::STATE_FOO;
- scoped_ptr<ListValue> results =
+ scoped_ptr<base::ListValue> results =
ReturnsMultiple::Results::Create(5, some_object);
- DictionaryValue* expected_dict = new DictionaryValue();
+ base::DictionaryValue* expected_dict = new base::DictionaryValue();
expected_dict->SetString("state", "foo");
- ListValue expected;
- expected.Append(Value::CreateIntegerValue(5));
+ base::ListValue expected;
+ expected.Append(base::Value::CreateIntegerValue(5));
expected.Append(expected_dict);
EXPECT_TRUE(results->Equals(&expected));
}
« no previous file with comments | « tools/json_schema_compiler/test/arrays_unittest.cc ('k') | tools/json_schema_compiler/test/choices_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698