Source/core/animation/KeyframeEffectModelTest.cpp - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/KeyframeEffectModelTest.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/ImageStyleInterpolation.cpp ('k') | Source/core/animation/KeyframeEffectTest.cpp » ('j') | Source/core/css/CSSBasicShapes.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/KeyframeEffectModelTest.cpp

diff --git a/Source/core/animation/KeyframeEffectModelTest.cpp b/Source/core/animation/KeyframeEffectModelTest.cpp

index 1aece27cea7fc78145181ca17be679a1966706ca..f6638e1202f1cd32727031b4cb21db2ccd35dae7 100644

--- a/Source/core/animation/KeyframeEffectModelTest.cpp

+++ b/Source/core/animation/KeyframeEffectModelTest.cpp

@@ -83,7 +83,7 @@ void expectDoubleValue(double expectedValue, PassRefPtrWillBeRawPtr<Interpolatio

if (value->isLength())

actualValue = toAnimatableLength(value.get())->length(1, ValueRangeAll).value();

else

- actualValue = toCSSPrimitiveValue(toAnimatableUnknown(value.get())->toCSSValue().get())->getDoubleValue();

+ actualValue = toCSSPrimitiveValue(toAnimatableUnknown(value.get())->toCSSValue()).getDoubleValue();

EXPECT_FLOAT_EQ(static_cast<float>(expectedValue), actualValue);

}

« no previous file with comments | « Source/core/animation/ImageStyleInterpolation.cpp ('k') | Source/core/animation/KeyframeEffectTest.cpp » ('j') | Source/core/css/CSSBasicShapes.cpp » ('J')