Source/core/animation/KeyframeEffectTest.cpp - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/KeyframeEffectTest.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/KeyframeEffectModelTest.cpp ('k') | Source/core/animation/LengthBoxStyleInterpolation.h » ('j') | Source/core/css/CSSBasicShapes.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/KeyframeEffectTest.cpp

diff --git a/Source/core/animation/KeyframeEffectTest.cpp b/Source/core/animation/KeyframeEffectTest.cpp

index 5ee2ff3651e3d5a0bd3d71c9e8c1681d9f4e5c1a..85c3d3c543ff5e7388245414c1b505b80b2b4568 100644

--- a/Source/core/animation/KeyframeEffectTest.cpp

+++ b/Source/core/animation/KeyframeEffectTest.cpp

@@ -98,13 +98,11 @@ TEST_F(AnimationKeyframeEffectV8Test, CanCreateAnAnimation)

EXPECT_EQ(0, keyframes[0]->offset());

EXPECT_EQ(1, keyframes[1]->offset());

- const CSSValue* keyframe1Width = toStringKeyframe(keyframes[0].get())->cssPropertyValue(CSSPropertyWidth);

- const CSSValue* keyframe2Width = toStringKeyframe(keyframes[1].get())->cssPropertyValue(CSSPropertyWidth);

- ASSERT(keyframe1Width);

- ASSERT(keyframe2Width);

+ const CSSValue keyframe1Width = toStringKeyframe(keyframes[0].get())->cssPropertyValue(CSSPropertyWidth);

+ const CSSValue keyframe2Width = toStringKeyframe(keyframes[1].get())->cssPropertyValue(CSSPropertyWidth);

- EXPECT_EQ("100px", keyframe1Width->cssText());

- EXPECT_EQ("0px", keyframe2Width->cssText());

+ EXPECT_EQ("100px", keyframe1Width.cssText());

+ EXPECT_EQ("0px", keyframe2Width.cssText());

EXPECT_EQ(*(CubicBezierTimingFunction::preset(CubicBezierTimingFunction::EaseInOut)), keyframes[0]->easing());

EXPECT_EQ(*(CubicBezierTimingFunction::create(1, 1, 0.3, 0.3).get()), keyframes[1]->easing());