Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: Source/core/css/CSSBasicShapes.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSBasicShapes.cpp
diff --git a/Source/core/css/CSSBasicShapes.cpp b/Source/core/css/CSSBasicShapes.cpp
index fc86581878ff7559afb3406046fe8208e1fa0e70..6b8eac31794a17660a6bd045662465ce7bc57cf4 100644
--- a/Source/core/css/CSSBasicShapes.cpp
+++ b/Source/core/css/CSSBasicShapes.cpp
@@ -293,7 +293,7 @@ bool CSSBasicShapePolygon::equals(const CSSBasicShape& shape) const
if (!compareCSSValuePtr(m_referenceBox, rhs.m_referenceBox))
return false;
- return compareCSSValueVector(m_values, rhs.m_values);
+ return compareCSSValueObjectVector(m_values, rhs.m_values);
Timothy Loh 2015/06/02 04:54:02 OK, but you're going to have to make CSSBasicShape
sashab 2015/06/05 06:16:28 Yup; planning on doing all the primitive values et
}
DEFINE_TRACE(CSSBasicShapePolygon)

Powered by Google App Engine
This is Rietveld 408576698