Source/core/animation/ImageStyleInterpolation.cpp - Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/ImageStyleInterpolation.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Some small fixes to (hopefully) fix some broken tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/ImageStyleInterpolation.h ('k') | Source/core/animation/KeyframeEffectModelTest.cpp » ('j') | Source/core/css/CSSBasicShapes.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/ImageStyleInterpolation.cpp

diff --git a/Source/core/animation/ImageStyleInterpolation.cpp b/Source/core/animation/ImageStyleInterpolation.cpp

index fd0306b185fd403dc93e6a0dbd3eb875c74db4b4..f81b5a38cabb8728022ece932c6102fee3a981be 100644

--- a/Source/core/animation/ImageStyleInterpolation.cpp

+++ b/Source/core/animation/ImageStyleInterpolation.cpp

@@ -19,11 +19,11 @@ void ImageStyleInterpolation::apply(StyleResolverState& state) const

{

double cachedValue = toInterpolableNumber(m_cachedValue.get())->value();

if (cachedValue <= 0.0) {

- StyleBuilder::applyProperty(m_id, state, m_initialImage.get());

+ StyleBuilder::applyProperty(m_id, state, m_initialImage);

return;

}

if (cachedValue >= 1.0) {

- StyleBuilder::applyProperty(m_id, state, m_finalImage.get());

+ StyleBuilder::applyProperty(m_id, state, m_finalImage);

return;

}

RefPtrWillBeRawPtr<CSSCrossfadeValue> crossfadeValue = CSSCrossfadeValue::create(m_initialImage, m_finalImage);

« no previous file with comments | « Source/core/animation/ImageStyleInterpolation.h ('k') | Source/core/animation/KeyframeEffectModelTest.cpp » ('j') | Source/core/css/CSSBasicShapes.cpp » ('J')