Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1164443002: Revert of Add direct getter for GrCaps to GrContext. (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add direct getter for GrCaps to GrContext. (patchset #4 id:60001 of https://codereview.chromium.org/1149773005/) Reason for revert: Breaking Original issue's description: > Add direct getter for GrCaps to GrContext. > > TBR=joshualitt@google.com > > Committed: https://skia.googlesource.com/skia/+/9138c46e572085870638b6f7ad7fcdfcdf3cac99 TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/084d1b61bca3b9e246cdf26377c373744ab6411c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -56 lines) Patch
M bench/nanobench.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M include/gpu/GrContext.h View 3 chunks +39 lines, -4 lines 0 comments Download
M src/core/SkPictureShader.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrAddPathRenderers_default.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBlurUtils.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 6 chunks +29 lines, -6 lines 0 comments Download
M src/gpu/GrCoordTransform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDashLinePathRenderer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrDashLinePathRenderer.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/SkGr.cpp View 6 chunks +7 lines, -10 lines 0 comments Download
M tests/GrDrawTargetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Add direct getter for GrCaps to GrContext.
5 years, 6 months ago (2015-05-28 15:20:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164443002/1
5 years, 6 months ago (2015-05-28 15:20:51 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 15:21:04 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/084d1b61bca3b9e246cdf26377c373744ab6411c

Powered by Google App Engine
This is Rietveld 408576698