Mac: Only allow NSOpenGLContext displaying on the main display

Mac: Only allow NSOpenGLContext displaying on the main display

Perhaps indicating that we're entering a losing struggle, using an layer
backed NSOpenGLContext with IOSurfaces on a non-primary display results
in terrible jank (it appears to be due to paging the IOSurface ... where
to and from is unclear).

Add support to dynamically switch between this and the CAOpenGLLayer
with IOSurface mode (which doesn't exhibit this problem).

Also add support for querying the current CGLRendererID (since I was
hoping this to solve the problem ... it didn't).

BUG=496484
Committed: https://crrev.com/347a77b6fac3ce9d1aa2d2b86bb4ce14583aa7a1
Cr-Commit-Position: refs/heads/master@{#333824}

[ccameron, 2015-06-10 01:09:33]

ccameron@chromium.org changed reviewers:
+ andresantoso@chromium.org

[ccameron, 2015-06-10 01:09:34]

This falls in the "horrible and unpredictable bugs" category.

[Andre, 2015-06-10 05:23:40]

LGTM

https://codereview.chromium.org/1164363005/diff/1/ui/accelerated_widget_mac/i...
File ui/accelerated_widget_mac/io_surface_ns_gl_surface.mm (right):

https://codereview.chromium.org/1164363005/diff/1/ui/accelerated_widget_mac/i...
ui/accelerated_widget_mac/io_surface_ns_gl_surface.mm:153: CGLContextObj
cgl_context = static_cast<CGLContextObj>(
Why do you need this cast?

[ccameron, 2015-06-10 21:39:51]

Thanks!

https://codereview.chromium.org/1164363005/diff/1/ui/accelerated_widget_mac/i...
File ui/accelerated_widget_mac/io_surface_ns_gl_surface.mm (right):

https://codereview.chromium.org/1164363005/diff/1/ui/accelerated_widget_mac/i...
ui/accelerated_widget_mac/io_surface_ns_gl_surface.mm:153: CGLContextObj
cgl_context = static_cast<CGLContextObj>(
On 2015/06/10 05:23:39, Andre wrote:
> Why do you need this cast?

-[NSOpenGLContext CGLContextObj] returns a void*, for unclear reasons. I was
surprised by this, too.

[ccameron, 2015-06-10 22:36:06]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2015-06-10 22:36:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
andresantoso@chromium.org
Link to the patchset: https://codereview.chromium.org/1164363005/#ps20001
(title: "Add GPU switch")

[commit-bot: I haz the power, 2015-06-10 22:36:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1164363005/20001

[commit-bot: I haz the power, 2015-06-10 22:44:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-10 22:45:35]

Patchset 2 (id:??) landed as
https://crrev.com/347a77b6fac3ce9d1aa2d2b86bb4ce14583aa7a1
Cr-Commit-Position: refs/heads/master@{#333824}