Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1163603004: Remove candidate show/hide/update related code (Closed)

Created:
5 years, 6 months ago by kochi
Modified:
5 years, 6 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, piman+watch_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, tfarina, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove candidate show/hide/update related code This is the second half of removing W3C IME API code on Chromium side. The first half is: https://codereview.chromium.org/1150953003/ OnCandidate* interface of TextInputClient is no longer used by anyone once Blink removes IME API code. ViewMsg_CandidateWindow* IPC messages are also no longer necessary. This CL depends on the change on Blink side https://codereview.chromium.org/1162853002/ to be rolled to Chromium. BUG=494856 Committed: https://crrev.com/32dbfae08fffc0677d56e56db9ebe2df7f632bf1 Cr-Commit-Position: refs/heads/master@{#332601}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -266 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +0 lines, -13 lines 0 comments Download
M ui/base/ime/dummy_text_input_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/base/ime/dummy_text_input_client.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/base/ime/input_method_base.h View 2 chunks +0 lines, -14 lines 0 comments Download
M ui/base/ime/input_method_base.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M ui/base/ime/input_method_base_unittest.cc View 2 chunks +0 lines, -68 lines 0 comments Download
M ui/base/ime/input_method_win.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/base/ime/remote_input_method_win.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/base/ime/remote_input_method_win_unittest.cc View 6 chunks +1 line, -25 lines 0 comments Download
M ui/base/ime/text_input_client.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/views/controls/prefix_selector.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/controls/prefix_selector.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/views/ime/input_method_bridge.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/ime/input_method_bridge.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163603004/1
5 years, 6 months ago (2015-06-01 07:49:54 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/77022)
5 years, 6 months ago (2015-06-01 08:11:18 UTC) #4
kochi
Shiino-san, Could you review this?
5 years, 6 months ago (2015-06-02 02:15:34 UTC) #6
Yuki
lgtm
5 years, 6 months ago (2015-06-02 04:58:24 UTC) #7
kochi
Avi, could you review content/* ? Daniel, could you review content/common/view_messages.h? Sky, could you review ...
5 years, 6 months ago (2015-06-02 05:30:11 UTC) #9
dcheng
rs lgtm for deletions in view_messages.h
5 years, 6 months ago (2015-06-02 05:36:03 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163603004/20001
5 years, 6 months ago (2015-06-02 07:53:43 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-02 09:04:46 UTC) #14
sky
ui/views LGTM
5 years, 6 months ago (2015-06-02 16:13:37 UTC) #15
kochi
Jochen, could you OWNERS review for content/* ? (in case Avi is not available)
5 years, 6 months ago (2015-06-03 01:13:16 UTC) #17
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-03 10:49:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163603004/20001
5 years, 6 months ago (2015-06-03 11:07:49 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-03 12:22:37 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 12:23:28 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32dbfae08fffc0677d56e56db9ebe2df7f632bf1
Cr-Commit-Position: refs/heads/master@{#332601}

Powered by Google App Engine
This is Rietveld 408576698