Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: ui/base/ime/input_method_base.h

Issue 1163603004: Remove candidate show/hide/update related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/dummy_text_input_client.cc ('k') | ui/base/ime/input_method_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_base.h
diff --git a/ui/base/ime/input_method_base.h b/ui/base/ime/input_method_base.h
index d014500717aeb0cf64422d27be277829ff338590..63783880dba9c24d3a88317772f74a3911cd7481 100644
--- a/ui/base/ime/input_method_base.h
+++ b/ui/base/ime/input_method_base.h
@@ -85,14 +85,6 @@ class UI_BASE_IME_EXPORT InputMethodBase
// |client| which is the text input client with focus.
void NotifyTextInputCaretBoundsChanged(const TextInputClient* client);
- // Interface for for signalling candidate window events.
- // See also *Callback functions below. To avoid reentrancy issue that
- // TextInputClient manipulates IME state during even handling, these methods
- // defer sending actual signals to renderer.
- void OnCandidateWindowShown();
- void OnCandidateWindowUpdated();
- void OnCandidateWindowHidden();
-
bool system_toplevel_window_focused() const {
return system_toplevel_window_focused_;
}
@@ -100,12 +92,6 @@ class UI_BASE_IME_EXPORT InputMethodBase
private:
void SetFocusedTextInputClientInternal(TextInputClient* client);
- // Deferred callbacks for signalling TextInputClient about candidate window
- // appearance changes.
- void CandidateWindowShownCallback();
- void CandidateWindowUpdatedCallback();
- void CandidateWindowHiddenCallback();
-
internal::InputMethodDelegate* delegate_;
TextInputClient* text_input_client_;
« no previous file with comments | « ui/base/ime/dummy_text_input_client.cc ('k') | ui/base/ime/input_method_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698