Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: ui/base/ime/input_method_win.cc

Issue 1163603004: Remove candidate show/hide/update related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/input_method_base_unittest.cc ('k') | ui/base/ime/remote_input_method_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_win.cc
diff --git a/ui/base/ime/input_method_win.cc b/ui/base/ime/input_method_win.cc
index 9bea264937c2a4dfc84b06741e472f3fe4aa7b31..29413f58e8c3f55d00fcce7f3d2eec582450e326 100644
--- a/ui/base/ime/input_method_win.cc
+++ b/ui/base/ime/input_method_win.cc
@@ -366,25 +366,13 @@ LRESULT InputMethodWin::OnImeNotify(UINT message,
*handled = FALSE;
- bool previous_state = is_candidate_popup_open_;
-
// Update |is_candidate_popup_open_|, whether a candidate window is open.
switch (wparam) {
case IMN_OPENCANDIDATE:
is_candidate_popup_open_ = true;
- if (!previous_state)
- OnCandidateWindowShown();
break;
case IMN_CLOSECANDIDATE:
is_candidate_popup_open_ = false;
- if (previous_state)
- OnCandidateWindowHidden();
- break;
- case IMN_CHANGECANDIDATE:
- // TODO(kochi): The IME API expects this event to notify window size change,
- // while this may fire more often without window resize. There is no generic
- // way to get bounds of candidate window.
- OnCandidateWindowUpdated();
break;
}
« no previous file with comments | « ui/base/ime/input_method_base_unittest.cc ('k') | ui/base/ime/remote_input_method_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698