ui/base/ime/remote_input_method_win.cc - Issue 1163603004: Remove candidate show/hide/update related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/remote_input_method_win.cc

Issue 1163603004: Remove candidate show/hide/update related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/ime/remote_input_method_win.cc

diff --git a/ui/base/ime/remote_input_method_win.cc b/ui/base/ime/remote_input_method_win.cc

index b921382aa8c2b06c217274a56d0e5196fe32b2f1..9735b0e5bb881c687b278e623562827233797efd 100644

--- a/ui/base/ime/remote_input_method_win.cc

+++ b/ui/base/ime/remote_input_method_win.cc

@@ -301,14 +301,6 @@ class RemoteInputMethodWin : public InputMethod,

void OnCandidatePopupChanged(bool visible) override {

is_candidate_popup_open_ = visible;

- if (!text_input_client_)

- return;

- // TODO(kochi): Support 'update' case, in addition to show/hide.

- // http://crbug.com/238585

- if (visible)

- text_input_client_->OnCandidateWindowShown();

- else

- text_input_client_->OnCandidateWindowHidden();

}

void OnInputSourceChanged(LANGID langid, bool /*is_ime*/) override {

« no previous file with comments | « ui/base/ime/input_method_win.cc ('k') | ui/base/ime/remote_input_method_win_unittest.cc » ('j') | no next file with comments »