Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1162883002: Credential Manager: Align 'FederatedCredential' with the spec. (Closed)

Created:
5 years, 6 months ago by Mike West
Modified:
5 years, 6 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Credential Manager: Align 'FederatedCredential' with the spec. * Renames 'federation' to 'provider' * Stubs out 'protocol' * Converts constructor to a dictionary (and also introduces the {,LocallyStored,Federated,Password}CredentialData chain of dictionary definitions to support this new constructor style) BUG=494880 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196309

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : no-find-copies #

Patch Set 4 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -60 lines) Patch
M LayoutTests/http/tests/credentialmanager/credentialscontainer-notifyfailedsignin-basics.html View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/http/tests/credentialmanager/credentialscontainer-notifysignedin-basics.html View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html View 2 chunks +33 lines, -11 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A Source/modules/credentialmanager/CredentialData.idl View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M Source/modules/credentialmanager/FederatedCredential.h View 1 chunk +7 lines, -13 lines 0 comments Download
M Source/modules/credentialmanager/FederatedCredential.cpp View 3 chunks +9 lines, -8 lines 0 comments Download
M Source/modules/credentialmanager/FederatedCredential.idl View 1 chunk +7 lines, -2 lines 0 comments Download
A Source/modules/credentialmanager/FederatedCredentialData.idl View 1 chunk +9 lines, -0 lines 0 comments Download
A Source/modules/credentialmanager/LocallyStoredCredentialData.idl View 1 chunk +10 lines, -0 lines 0 comments Download
A Source/modules/credentialmanager/PasswordCredentialData.idl View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 2 chunks +12 lines, -0 lines 0 comments Download
M Source/platform/credentialmanager/PlatformFederatedCredential.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/credentialmanager/PlatformFederatedCredential.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/exported/WebFederatedCredential.cpp View 2 chunks +4 lines, -10 lines 0 comments Download
M public/platform/WebFederatedCredential.h View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Mike West
WDYT, Jochen? +Vaclav, as it would be good to start getting someone else familiar with ...
5 years, 6 months ago (2015-06-01 07:34:03 UTC) #2
vabr (Chromium)
LGTM, thanks for looping me in. Vaclav
5 years, 6 months ago (2015-06-01 07:59:14 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-01 08:34:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162883002/20001
5 years, 6 months ago (2015-06-01 11:34:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/57087)
5 years, 6 months ago (2015-06-01 11:37:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162883002/40001
5 years, 6 months ago (2015-06-01 11:54:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64156)
5 years, 6 months ago (2015-06-01 13:43:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162883002/60001
5 years, 6 months ago (2015-06-02 06:48:01 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64755)
5 years, 6 months ago (2015-06-02 09:38:01 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162883002/60001
5 years, 6 months ago (2015-06-02 09:56:41 UTC) #20
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 11:16:38 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196309

Powered by Google App Engine
This is Rietveld 408576698