Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1163493003: Credential Management: Reorder Web*Credential arguments. (Closed)

Created:
5 years, 6 months ago by Mike West
Modified:
5 years, 6 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-content_chromium.org, vabr+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Credential Management: Reorder Web*Credential arguments. BUG=494880 Committed: https://crrev.com/31e8b4f1001e523bcb45529a7aac3ca91184b16c Cr-Commit-Position: refs/heads/master@{#332177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/password_manager/content/renderer/credential_manager_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Mike West
Tiny rename. There are going to be tons more of these. -mike
5 years, 6 months ago (2015-06-01 07:15:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163493003/1
5 years, 6 months ago (2015-06-01 07:33:12 UTC) #4
vabr (Chromium)
LGTM
5 years, 6 months ago (2015-06-01 07:44:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163493003/1
5 years, 6 months ago (2015-06-01 07:54:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163493003/1
5 years, 6 months ago (2015-06-01 10:53:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 10:56:46 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 10:57:32 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/31e8b4f1001e523bcb45529a7aac3ca91184b16c
Cr-Commit-Position: refs/heads/master@{#332177}

Powered by Google App Engine
This is Rietveld 408576698