Source/modules/credentialmanager/FederatedCredential.idl - Issue 1162883002: Credential Manager: Align 'FederatedCredential' with the spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/credentialmanager/FederatedCredential.idl

Issue 1162883002: Credential Manager: Align 'FederatedCredential' with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Test. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/credentialmanager/FederatedCredential.cpp ('k') | Source/modules/credentialmanager/FederatedCredentialData.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/credentialmanager/FederatedCredential.idl

diff --git a/Source/modules/credentialmanager/FederatedCredential.idl b/Source/modules/credentialmanager/FederatedCredential.idl

index c22d25086fb1bb3a4716dd35d3618189542b6bd8..848ed8dff565150a9c7c65eb5318cc0373ecd939 100644

--- a/Source/modules/credentialmanager/FederatedCredential.idl

+++ b/Source/modules/credentialmanager/FederatedCredential.idl

@@ -2,10 +2,15 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+// https://w3c.github.io/webappsec/specs/credentialmanagement/#federatedcredential

[

RuntimeEnabled=CredentialManager,

RaisesException=Constructor,

- Constructor(DOMString id, DOMString federation, optional DOMString name, optional DOMString avatarURL)

+ Constructor(FederatedCredentialData data)

] interface FederatedCredential : Credential {

- readonly attribute DOMString federation;

+ readonly attribute USVString provider;

+ // TODO(mkwst): We don't really support this yet; it always returns ''.

+ readonly attribute DOMString? protocol;

};