Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1844)

Unified Diff: Source/modules/credentialmanager/FederatedCredential.cpp

Issue 1162883002: Credential Manager: Align 'FederatedCredential' with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Test. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/FederatedCredential.cpp
diff --git a/Source/modules/credentialmanager/FederatedCredential.cpp b/Source/modules/credentialmanager/FederatedCredential.cpp
index f2456802e87961f87be0222196fd06f342a3c1bb..4466e5aa408f963c2f3a5ceae6792cc04acdbfb0 100644
--- a/Source/modules/credentialmanager/FederatedCredential.cpp
+++ b/Source/modules/credentialmanager/FederatedCredential.cpp
@@ -6,6 +6,7 @@
#include "modules/credentialmanager/FederatedCredential.h"
#include "bindings/core/v8/ExceptionState.h"
+#include "modules/credentialmanager/FederatedCredentialData.h"
#include "platform/credentialmanager/PlatformFederatedCredential.h"
#include "public/platform/WebFederatedCredential.h"
@@ -16,13 +17,13 @@ FederatedCredential* FederatedCredential::create(WebFederatedCredential* webFede
return new FederatedCredential(webFederatedCredential);
}
-FederatedCredential* FederatedCredential::create(const String& id, const String& federation, const String& name, const String& avatar, ExceptionState& exceptionState)
+FederatedCredential* FederatedCredential::create(const FederatedCredentialData& data, ExceptionState& exceptionState)
{
- KURL avatarURL = parseStringAsURL(avatar, exceptionState);
- KURL federationURL = parseStringAsURL(federation, exceptionState);
+ KURL iconURL = parseStringAsURL(data.iconURL(), exceptionState);
+ KURL providerURL = parseStringAsURL(data.provider(), exceptionState);
if (exceptionState.hadException())
return nullptr;
- return new FederatedCredential(id, federationURL, name, avatarURL);
+ return new FederatedCredential(data.id(), providerURL, data.name(), iconURL);
}
FederatedCredential::FederatedCredential(WebFederatedCredential* webFederatedCredential)
@@ -30,14 +31,14 @@ FederatedCredential::FederatedCredential(WebFederatedCredential* webFederatedCre
{
}
-FederatedCredential::FederatedCredential(const String& id, const KURL& federation, const String& name, const KURL& avatar)
- : Credential(PlatformFederatedCredential::create(id, federation, name, avatar))
+FederatedCredential::FederatedCredential(const String& id, const KURL& provider, const String& name, const KURL& icon)
+ : Credential(PlatformFederatedCredential::create(id, provider, name, icon))
{
}
-const KURL& FederatedCredential::federation() const
+const KURL& FederatedCredential::provider() const
{
- return static_cast<PlatformFederatedCredential*>(m_platformCredential.get())->federation();
+ return static_cast<PlatformFederatedCredential*>(m_platformCredential.get())->provider();
}
} // namespace blink
« no previous file with comments | « Source/modules/credentialmanager/FederatedCredential.h ('k') | Source/modules/credentialmanager/FederatedCredential.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698