Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1162243003: BackgroundSync sync events need to be ExtendableEvents, content side (Closed)

Created:
5 years, 6 months ago by chasej
Modified:
5 years, 6 months ago
Reviewers:
Tom Sepez, michaeln, jkarlin
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BackgroundSync sync events need to be ExtendableEvents, content side This is part of a series of patches to correctly fire the Sync event as an ExtendableEvent, instead of a regular Event [1/4] This patch, content side fix [2/4] https://codereview.chromium.org/1148293011/, blink side fix [3/4] https://codereview.chromium.org/1160253004/, content browser tests [4/4] https://codereview.chromium.org/1146063005/, cleanup Specific changes in this patch - Sync event finished handling accepts the result of the waitUntil promise - The worker status will be set correctly if the promise was rejected - Overload of existing public/web interface provided for compatibility with blink implementation BUG=486890 Committed: https://crrev.com/b2bc492b3a8709bd3398cf4ea18ddc1909286d2d Cr-Commit-Position: refs/heads/master@{#332787}

Patch Set 1 #

Patch Set 2 : Avoid race condition in sync event dispatch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -10 lines) Patch
M content/browser/service_worker/service_worker_version.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 2 chunks +13 lines, -2 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 chunk +8 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_script_context.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
chasej
Please take a look, and recommend other reviewers.
5 years, 6 months ago (2015-06-02 17:43:35 UTC) #2
jkarlin
Nice, lgtm. Suggest adding tsepez for service_worker_messages.h and michaeln for the rest.
5 years, 6 months ago (2015-06-03 14:59:06 UTC) #3
chasej
tsepez, please take a look at service_worker_messages.h. michaeln, please take a look at the rest ...
5 years, 6 months ago (2015-06-03 15:42:57 UTC) #5
Tom Sepez
Messages LGTM
5 years, 6 months ago (2015-06-03 19:43:02 UTC) #6
michaeln
lgtm 2
5 years, 6 months ago (2015-06-04 03:00:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162243003/20001
5 years, 6 months ago (2015-06-04 04:53:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-04 05:53:11 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 05:54:20 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b2bc492b3a8709bd3398cf4ea18ddc1909286d2d
Cr-Commit-Position: refs/heads/master@{#332787}

Powered by Google App Engine
This is Rietveld 408576698