Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 1162243003: BackgroundSync sync events need to be ExtendableEvents, content side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Avoid race condition in sync event dispatch Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index 924c55be239d9d4724c7ff54264b303d4d0d6917..9964b8a46697cfd1c3822473c21ebc2fb8dfb3f4 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -1328,7 +1328,8 @@ void ServiceWorkerVersion::OnFetchEventFinished(
}
void ServiceWorkerVersion::OnSyncEventFinished(
- int request_id) {
+ int request_id,
+ blink::WebServiceWorkerEventResult result) {
TRACE_EVENT1("ServiceWorker",
"ServiceWorkerVersion::OnSyncEventFinished",
"Request id", request_id);
@@ -1338,8 +1339,18 @@ void ServiceWorkerVersion::OnSyncEventFinished(
return;
}
+ ServiceWorkerStatusCode status = SERVICE_WORKER_OK;
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableServiceWorkerSync)) {
+ // Avoid potential race condition where flag is disabled after a sync event
+ // was dispatched
+ status = SERVICE_WORKER_ERROR_ABORT;
+ } else if (result == blink::WebServiceWorkerEventResultRejected) {
+ status = SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED;
+ }
+
scoped_refptr<ServiceWorkerVersion> protect(this);
- callback->Run(SERVICE_WORKER_OK);
+ callback->Run(status);
RemoveCallbackAndStopIfRedundant(&sync_callbacks_, request_id);
}
« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698