content/browser/service_worker/service_worker_version.h - Issue 1162243003: BackgroundSync sync events need to be ExtendableEvents, content side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1162243003: BackgroundSync sync events need to be ExtendableEvents, content side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Avoid race condition in sync event dispatch Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index f52170965a12d2d2a95adf1813e76336adff720b..481afed3732be8d3975f7dc930378453b418352c 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -416,7 +416,8 @@ class CONTENT_EXPORT ServiceWorkerVersion

void OnFetchEventFinished(int request_id,

ServiceWorkerFetchEventResult result,

const ServiceWorkerResponse& response);

- void OnSyncEventFinished(int request_id);

+ void OnSyncEventFinished(int request_id,

+ blink::WebServiceWorkerEventResult result);

void OnNotificationClickEventFinished(int request_id);

void OnPushEventFinished(int request_id,

blink::WebServiceWorkerEventResult result);

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »