content/renderer/service_worker/embedded_worker_context_client.h - Issue 1162243003: BackgroundSync sync events need to be ExtendableEvents, content side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_context_client.h

Issue 1162243003: BackgroundSync sync events need to be ExtendableEvents, content side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Avoid race condition in sync event dispatch Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/service_worker/service_worker_messages.h ('k') | content/renderer/service_worker/embedded_worker_context_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/embedded_worker_context_client.h

diff --git a/content/renderer/service_worker/embedded_worker_context_client.h b/content/renderer/service_worker/embedded_worker_context_client.h

index cc1cba17243e1f4998a395154c387170b0c8f78c..9511ac767ce80f6c19882902aa70815bf9718db0 100644

--- a/content/renderer/service_worker/embedded_worker_context_client.h

+++ b/content/renderer/service_worker/embedded_worker_context_client.h

@@ -104,7 +104,10 @@ class EmbeddedWorkerContextClient

blink::WebServiceWorkerEventResult result);

virtual void didHandlePushEvent(int request_id,

blink::WebServiceWorkerEventResult result);

+ // TODO(chasej): crbug.com/486890 - Remove when matching blink changes land

virtual void didHandleSyncEvent(int request_id);

+ virtual void didHandleSyncEvent(int request_id,

+ blink::WebServiceWorkerEventResult result);

virtual void didHandleCrossOriginConnectEvent(int request_id,

bool accept_connection);