Issue 1160433004: Revert of Add MarkRole in blink side to expose mark tag properly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160433004: Revert of Add MarkRole in blink side to expose mark tag properly (Closed)

Created:
5 years, 6 months ago by Justin Novosad

Modified:
5 years, 6 months ago

Reviewers:
shreeramk, Mike West, dmazzoni

CC:
blink-reviews, dglazkov+blink, aboxhall, mkwst+moarreviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Add MarkRole in blink side to expose mark tag properly (patchset #5 id:80001 of https://codereview.chromium.org/653683005/) Reason for revert: content_browsertests DumpAccessibilityTreeTest.AccessibilityMark Failing on win7 and Mac. https://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/10071/steps/content_browsertests/logs/DumpAccessibilityTreeTest.AccessibilityMark Original issue's description: > Add MarkRole in blink side to expose mark tag properly > > Make HTML5 <mark> accessible. > > According to latest editor's draft http://w3c.github.io/aria/html-aam/html-aam.html#el-mark > > This will be followed by a chromium side CL which will take care of exposing mark tag with IA 2 Role. > > BUG=494612 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196310 TBR=dmazzoni@chromium.org,mkwst@chromium.org,shreeram.k@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=494612 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196338

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -10 lines)			Patch
M	Source/modules/accessibility/AXLayoutObject.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/modules/accessibility/AXNodeObject.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/modules/accessibility/AXObject.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/modules/accessibility/AXObject.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/AssertMatchingEnums.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	public/web/WebAXEnums.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Justin Novosad

Created Revert of Add MarkRole in blink side to expose mark tag properly

5 years, 6 months ago (2015-06-02 19:46:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160433004/1

5 years, 6 months ago (2015-06-02 19:47:21 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-02 19:48:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196338