Add MarkRole in blink side to expose mark tag properly

Add MarkRole in blink side to expose mark tag properly

Make HTML5 <mark> accessible.

According to latest editor's draft http://w3c.github.io/aria/html-aam/html-aam.html#el-mark

This will be followed by a chromium side CL which will take care of exposing mark tag with IA 2 Role.

BUG=494612
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196825

[shreeramk, 2014-10-14 17:06:02]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org, mkwst@chromium.org

[shreeramk, 2014-10-14 17:06:02]

Please review.

*_chromium_* try bots are failing because the blink roll is not done yet for rev
183638(This rev id is related with the dependent CL of meter tag)

Anyways *_chromium_* side try bots failure doesn't affect this CL.

Thanks!

[dmazzoni, 2014-10-14 17:15:13]

The spec for IAccessible2 says "Doesn't have an accessible", which means
accessibilityIsIgnored should return true - which is how it was behaving before.

Since the spec basically says that this element doesn't have any specific
meaning, I'm tempted to leave it alone - or else we should have just a single
role for all of the HTML span-level elements that don't map to a specific AX
role.

[shreeramk, 2014-10-14 17:42:30]

On 2014/10/14 17:15:13, dmazzoni wrote:
> The spec for IAccessible2 says "Doesn't have an accessible", which means
> accessibilityIsIgnored should return true - which is how it was behaving
before.

Ok. Got it.

But, in this scenario then MSAA+UIA doesn't matter??


So, this CL is not required??

[shreeramk, 2014-10-14 17:45:16]

On 2014/10/14 17:42:30, shreeram.k wrote:
> On 2014/10/14 17:15:13, dmazzoni wrote:
> > The spec for IAccessible2 says "Doesn't have an accessible", which means
> > accessibilityIsIgnored should return true - which is how it was behaving
> before.
> 
> Ok. Got it.
> 
> But, in this scenario then MSAA+UIA doesn't matter??
> 
> 
> So, this CL is not required??


But on MAC, this is accessible. Then how we can ignore the accesssibility?

AXRole: AXGroup
AXSubrole: (nil)
AXRoleDescription: "group"

[dmazzoni, 2014-10-15 16:14:15]

On 2014/10/14 17:45:16, shreeram.k wrote:
> > But, in this scenario then MSAA+UIA doesn't matter??

We don't currently support UIA. It's not as high a priority and I don't want to
worry about it much until IA2 is working really well.

Also, it's not clear what to do when MSAA+UIA and MSAA+IA2 conflict - there's
just one COM object that supports all three interfaces, so we can't return two
different things for the role. I asked one of the spec authors to help clarify.

> But on MAC, this is accessible. Then how we can ignore the accesssibility?
> 
> AXRole: AXGroup
> AXSubrole: (nil)
> AXRoleDescription: "group"

AXGroup is a completely generic role, it gets ignored by VoiceOver, so it
doesn't really matter if we include it with a role of AXGroup or exclude it from
the tree. I'd say we're compliant with the spec either way.

I'd say we drop this one for now.

[shreeramk, 2014-10-15 16:45:27]

On 2014/10/15 16:14:15, dmazzoni wrote:
> On 2014/10/14 17:45:16, shreeram.k wrote:
> > > But, in this scenario then MSAA+UIA doesn't matter??
> 
> We don't currently support UIA. It's not as high a priority and I don't want
to
> worry about it much until IA2 is working really well.
> 
> Also, it's not clear what to do when MSAA+UIA and MSAA+IA2 conflict - there's
> just one COM object that supports all three interfaces, so we can't return two
> different things for the role. I asked one of the spec authors to help
clarify.
> 
> > But on MAC, this is accessible. Then how we can ignore the accesssibility?
> > 
> > AXRole: AXGroup
> > AXSubrole: (nil)
> > AXRoleDescription: "group"
> 
> AXGroup is a completely generic role, it gets ignored by VoiceOver, so it
> doesn't really matter if we include it with a role of AXGroup or exclude it
from
> the tree. I'd say we're compliant with the spec either way.
> 
> I'd say we drop this one for now.

Yes true... I'd drop this for now.

[shreeramk, 2015-06-01 07:08:39]

@Dominic - Spec has been updated for Mark tag. Now, IA2 role and
AXRoleDescription has been defined for Mark tag. PTAL. Thanks.

[dmazzoni, 2015-06-01 17:09:10]

I don't see where you're assigning the role. You should probably add it to
AXNodeObject::determineAccessibilityRoleUtil

[shreeramk, 2015-06-01 17:31:03]

On 2015/06/01 17:09:10, dmazzoni wrote:
> I don't see where you're assigning the role. You should probably add it to
> AXNodeObject::determineAccessibilityRoleUtil

Ohh I think while rebasing I missed it, since it was an old CL.

[shreeramk, 2015-06-02 04:57:16]

Updated the code. PTAL. Thanks.

[dmazzoni, 2015-06-02 05:23:24]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-06-02 05:23:24]

lgtm

[commit-bot: I haz the power, 2015-06-02 05:23:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/653683005/80001

[commit-bot: I haz the power, 2015-06-02 06:45:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 06:45:48]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64726)

[shreeramk, 2015-06-02 12:07:20]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2015-06-02 12:07:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/653683005/80001

[commit-bot: I haz the power, 2015-06-02 12:11:18]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196310

[Justin Novosad, 2015-06-02 19:46:27]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1160433004/ by junov@chromium.org.

The reason for reverting is: content_browsertests
DumpAccessibilityTreeTest.AccessibilityMark
Failing on win7 and Mac. 

https://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/100....

[shreeramk, 2015-06-10 03:07:38]

The CQ bit was checked by shreeram.k@samsung.com

[shreeramk, 2015-06-10 03:07:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/653683005/#ps100001
(title: "reland")

[commit-bot: I haz the power, 2015-06-10 03:07:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/653683005/100001

[commit-bot: I haz the power, 2015-06-10 04:26:21]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196825