Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: Source/modules/accessibility/AXLayoutObject.cpp

Issue 1160433004: Revert of Add MarkRole in blink side to expose mark tag properly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/modules/accessibility/AXNodeObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 633 matching lines...) Expand 10 before | Expand all | Expand 10 after
644 644
645 if (roleValue() == MeterRole) 645 if (roleValue() == MeterRole)
646 return false; 646 return false;
647 647
648 if (roleValue() == RubyRole) 648 if (roleValue() == RubyRole)
649 return false; 649 return false;
650 650
651 if (roleValue() == TimeRole) 651 if (roleValue() == TimeRole)
652 return false; 652 return false;
653 653
654 if (roleValue() == MarkRole)
655 return false;
656
657 // if this element has aria attributes on it, it should not be ignored. 654 // if this element has aria attributes on it, it should not be ignored.
658 if (supportsARIAAttributes()) 655 if (supportsARIAAttributes())
659 return false; 656 return false;
660 657
661 // <span> tags are inline tags and not meant to convey information if they h ave no other aria 658 // <span> tags are inline tags and not meant to convey information if they h ave no other aria
662 // information on them. If we don't ignore them, they may emit signals expec ted to come from 659 // information on them. If we don't ignore them, they may emit signals expec ted to come from
663 // their parent. In addition, because included spans are GroupRole objects, and GroupRole 660 // their parent. In addition, because included spans are GroupRole objects, and GroupRole
664 // objects are often containers with meaningful information, the inclusion o f a span can have 661 // objects are often containers with meaningful information, the inclusion o f a span can have
665 // the side effect of causing the immediate parent accessible to be ignored. This is especially 662 // the side effect of causing the immediate parent accessible to be ignored. This is especially
666 // problematic for platforms which have distinct roles for textual block ele ments. 663 // problematic for platforms which have distinct roles for textual block ele ments.
(...skipping 1820 matching lines...) Expand 10 before | Expand all | Expand 10 after
2487 if (label && label->layoutObject()) { 2484 if (label && label->layoutObject()) {
2488 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect(); 2485 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect();
2489 result.unite(labelRect); 2486 result.unite(labelRect);
2490 } 2487 }
2491 } 2488 }
2492 2489
2493 return result; 2490 return result;
2494 } 2491 }
2495 2492
2496 } // namespace blink 2493 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/modules/accessibility/AXNodeObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698