Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 116043006: [Telemetry]: Assert that page measurement results don't contain a '.' in their name. (Closed)

Created:
6 years, 11 months ago by rmcilroy
Modified:
6 years, 11 months ago
Reviewers:
nduca, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry]: Assert that page measurement results don't contain a '.' in their name. Telemetry uses a '.' to delimit chart_name and trace_names in Value types, so trace names cannot include a '.' in them. BUG=329845 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243186

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M tools/perf/measurements/tab_switching.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/perf/metrics/memory.py View 2 chunks +8 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_results.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmcilroy
Nat, please review this CL.
6 years, 11 months ago (2014-01-06 11:18:40 UTC) #1
tonyg
lgtm https://codereview.chromium.org/116043006/diff/1/tools/telemetry/telemetry/page/page_measurement_results.py File tools/telemetry/telemetry/page/page_measurement_results.py (right): https://codereview.chromium.org/116043006/diff/1/tools/telemetry/telemetry/page/page_measurement_results.py#newcode63 tools/telemetry/telemetry/page/page_measurement_results.py:63: assert('.' not in trace_name) Drop the parens and ...
6 years, 11 months ago (2014-01-06 15:41:25 UTC) #2
rmcilroy
Thanks Tony! https://codereview.chromium.org/116043006/diff/1/tools/telemetry/telemetry/page/page_measurement_results.py File tools/telemetry/telemetry/page/page_measurement_results.py (right): https://codereview.chromium.org/116043006/diff/1/tools/telemetry/telemetry/page/page_measurement_results.py#newcode63 tools/telemetry/telemetry/page/page_measurement_results.py:63: assert('.' not in trace_name) On 2014/01/06 15:41:25, ...
6 years, 11 months ago (2014-01-06 16:30:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/116043006/60001
6 years, 11 months ago (2014-01-06 16:31:09 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 22:24:58 UTC) #5
Message was sent while issue was closed.
Change committed as 243186

Powered by Google App Engine
This is Rietveld 408576698