tools/perf/measurements/tab_switching.py - Issue 116043006: [Telemetry]: Assert that page measurement results don't contain a '.' in their name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/tab_switching.py

Issue 116043006: [Telemetry]: Assert that page measurement results don't contain a '.' in their name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/tab_switching.py

diff --git a/tools/perf/measurements/tab_switching.py b/tools/perf/measurements/tab_switching.py

index 00511e2169b2844baafed9d34c92dc589e66ad1b..982f05f8c5d8ad6dc618f8d41ee3c73f8169da38 100644

--- a/tools/perf/measurements/tab_switching.py

+++ b/tools/perf/measurements/tab_switching.py

@@ -48,6 +48,7 @@ class TabSwitching(page_measurement.PageMeasurement):

histogram_name = 'MPArch.RWH_TabSwitchPaintDuration'

histogram_type = histogram_util.BROWSER_HISTOGRAM

+ display_name = 'MPArch_RWH_TabSwitchPaintDuration'

first_histogram = histogram_util.GetHistogram(

histogram_type, histogram_name, tab)

prev_histogram = first_histogram

@@ -70,5 +71,5 @@ class TabSwitching(page_measurement.PageMeasurement):

diff_histogram = histogram_util.SubtractHistogram(last_histogram,

first_histogram)

- results.AddSummary(histogram_name, '', diff_histogram,

+ results.AddSummary(display_name, '', diff_histogram,

data_type='unimportant-histogram')

« no previous file with comments | « no previous file | tools/perf/metrics/memory.py » ('j') | no next file with comments »