Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: tools/perf/metrics/memory.py

Issue 116043006: [Telemetry]: Assert that page measurement results don't contain a '.' in their name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/metrics/memory.py
diff --git a/tools/perf/metrics/memory.py b/tools/perf/metrics/memory.py
index b5a5fb753f3416ffe3bb35f61e1cd3ad454e4de5..87bda8f67783df65557e3c54c5f3b15e7a5d00b4 100644
--- a/tools/perf/metrics/memory.py
+++ b/tools/perf/metrics/memory.py
@@ -9,16 +9,22 @@ from metrics import Metric
_HISTOGRAMS = [
{'name': 'V8.MemoryExternalFragmentationTotal', 'units': 'percent',
+ 'display_name': 'V8_MemoryExternalFragmentationTotal',
'type': histogram_util.RENDERER_HISTOGRAM},
{'name': 'V8.MemoryHeapSampleTotalCommitted', 'units': 'kb',
+ 'display_name': 'V8_MemoryHeapSampleTotalCommitted',
'type': histogram_util.RENDERER_HISTOGRAM},
{'name': 'V8.MemoryHeapSampleTotalUsed', 'units': 'kb',
+ 'display_name': 'V8_MemoryHeapSampleTotalUsed',
'type': histogram_util.RENDERER_HISTOGRAM},
{'name': 'V8.MemoryHeapSampleMaximumCommitted', 'units': 'kb',
+ 'display_name': 'V8_MemoryHeapSampleMaximumCommitted',
'type': histogram_util.RENDERER_HISTOGRAM},
{'name': 'Memory.RendererUsed', 'units': 'kb',
+ 'display_name': 'Memory_RendererUsed',
'type': histogram_util.RENDERER_HISTOGRAM},
{'name': 'Memory.BrowserUsed', 'units': 'kb',
+ 'display_name': 'Memory_BrowserUsed',
'type': histogram_util.BROWSER_HISTOGRAM}]
class MemoryMetric(Metric):
@@ -87,7 +93,8 @@ class MemoryMetric(Metric):
# Histogram data may not be available
if h['name'] not in self._histogram_start:
continue
- results.Add(h['name'], h['units'], self._histogram_delta[h['name']],
+ results.Add(h['display_name'], h['units'],
+ self._histogram_delta[h['name']],
data_type='unimportant-histogram')
self._memory_stats = self._browser.memory_stats
if not self._memory_stats['Browser']:
« no previous file with comments | « tools/perf/measurements/tab_switching.py ('k') | tools/telemetry/telemetry/page/page_measurement_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698