tools/telemetry/telemetry/page/page_measurement_results.py - Issue 116043006: [Telemetry]: Assert that page measurement results don't contain a '.' in their name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_measurement_results.py

Issue 116043006: [Telemetry]: Assert that page measurement results don't contain a '.' in their name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_measurement_results.py

diff --git a/tools/telemetry/telemetry/page/page_measurement_results.py b/tools/telemetry/telemetry/page/page_measurement_results.py

index ef8208b9a7d1c8dc7c1bae05a6c5a425a33cb175..2ba34bd4665fa90424a137d72c6a2b22972b0700 100644

--- a/tools/telemetry/telemetry/page/page_measurement_results.py

+++ b/tools/telemetry/telemetry/page/page_measurement_results.py

@@ -58,6 +58,8 @@ class PageMeasurementResults(page_test_results.PageTestResults):

self._page_specific_values_for_current_page = []

def Add(self, trace_name, units, value, chart_name=None, data_type='default'):

+ assert '.' not in trace_name, ('Trace names cannot contain "." since this '

+ 'delimits chart_name.trace_name in Value objects.')

value = value_backcompat.ConvertOldCallingConventionToValue(

self._current_page,

trace_name, units, value, chart_name, data_type)

« no previous file with comments | « tools/perf/metrics/memory.py ('k') | no next file » | no next file with comments »