Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1159623009: content: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed)

Created:
5 years, 6 months ago by Sami
Modified:
5 years, 6 months ago
Reviewers:
no sievers
CC:
chromium-reviews, asanka, serviceworker-reviews, yusukes+watch_chromium.org, zea+watch_chromium.org, tzik, posciak+watch_chromium.org, Michael van Ouwerkerk, dcheng, sievers+watch_chromium.org, dgrogan, kinuko+watch, jdduke+watch_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, mlamouri+watch-geolocation_chromium.org, nona+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, kinuko+serviceworker, jbauman+watch_chromium.org, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, kalyank, zork+watch_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, wjmaclean, mlamouri+watch-notifications_chromium.org, penghuang+watch_chromium.org, timvolodine, feature-media-reviews_chromium.org, nhiroki, mlamouri+watch-sensors_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jsbell+idb_chromium.org, peter+watch_chromium.org, jochen+watch_chromium.org, maniscalco+watch_chromium.org, michaeln, riju_, maxbogue+watch_chromium.org, shuchen+watch_chromium.org, mcasas+watch_chromium.org, yurys, plaree+watch_chromium.org, cmumford, horo+watch_chromium.org, danakj+watch_chromium.org, James Su, wjia+watch_chromium.org, kinuko+fileapi, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Remove use of MessageLoopProxy and deprecated MessageLoop APIs This patch was mostly autogenerated with https://codereview.chromium.org/1010073002/. BUG=465354 TBR=nick@chromium.org Committed: https://crrev.com/422456f9d53f0bf936a64f21a1463fd0abd3df84 Cr-Commit-Position: refs/heads/master@{#333081} Committed: https://crrev.com/95082a6a47108c4e20a77cc224172a293065ab05 Cr-Commit-Position: refs/heads/master@{#333112}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review comments. #

Patch Set 3 : Build fix. #

Patch Set 4 : Unit test fix. #

Patch Set 5 : Test build fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1245 lines, -1212 lines) Patch
M chrome/browser/media_galleries/fileapi/safe_iapps_library_parser.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 3 chunks +12 lines, -16 lines 0 comments Download
M content/browser/appcache/appcache_group.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_quota_client_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_request_handler_unittest.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M content/browser/appcache/appcache_response.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_response_unittest.cc View 1 5 chunks +7 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_service_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_service_unittest.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl_unittest.cc View 9 chunks +20 lines, -25 lines 0 comments Download
M content/browser/appcache/appcache_update_job_unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M content/browser/appcache/appcache_url_request_job.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/appcache/appcache_url_request_job_unittest.cc View 1 4 chunks +8 lines, -6 lines 0 comments Download
M content/browser/appcache/chrome_appcache_service_unittest.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M content/browser/appcache/mock_appcache_service.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/appcache/mock_appcache_storage.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.cc View 30 chunks +48 lines, -33 lines 0 comments Download
M content/browser/background_sync/background_sync_manager_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/background_sync/background_sync_network_observer.cc View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 6 chunks +12 lines, -11 lines 0 comments Download
M content/browser/browser_shutdown_profile_dumper.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 5 chunks +21 lines, -22 lines 0 comments Download
M content/browser/browser_thread_unittest.cc View 5 chunks +14 lines, -12 lines 0 comments Download
M content/browser/byte_stream_unittest.cc View 16 chunks +31 lines, -47 lines 0 comments Download
M content/browser/cache_storage/cache_storage.cc View 5 chunks +13 lines, -10 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M content/browser/cache_storage/cache_storage_manager_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/cache_storage/cache_storage_scheduler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/compositor/reflector_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/compositor/reflector_impl_unittest.cc View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_ozone_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/database_quota_client_unittest.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M content/browser/database_tracker_unittest.cc View 3 chunks +7 lines, -13 lines 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory_base.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/tethering_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_area_unittest.cc View 7 chunks +16 lines, -19 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 4 chunks +19 lines, -25 lines 0 comments Download
M content/browser/dom_storage/dom_storage_task_runner.h View 5 chunks +6 lines, -5 lines 0 comments Download
M content/browser/dom_storage/dom_storage_task_runner.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/download/download_file_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/download_file_unittest.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/download/drag_download_file.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M content/browser/fileapi/blob_url_request_job_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/copy_or_move_file_validator_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 9 chunks +18 lines, -17 lines 0 comments Download
M content/browser/fileapi/dragged_file_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/fileapi/file_system_context_unittest.cc View 2 chunks +9 lines, -14 lines 0 comments Download
M content/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_write_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/fileapi/file_system_quota_client_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/fileapi/file_system_url_request_job_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_system_usage_cache_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/fileapi/file_writer_delegate_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M content/browser/fileapi/local_file_stream_reader_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/fileapi/local_file_stream_writer_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/local_file_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/fileapi/mock_file_change_observer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/fileapi/obfuscated_file_util_unittest.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M content/browser/fileapi/plugin_private_file_system_backend_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/fileapi/recursive_operation_delegate_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M content/browser/fileapi/sandbox_file_system_backend_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/fileapi/timed_task_helper_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/gamepad/gamepad_provider.h View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/gamepad/gamepad_provider.cc View 7 chunks +17 lines, -20 lines 0 comments Download
M content/browser/geofencing/geofencing_service.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/geofencing/mock_geofencing_service.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/geolocation/fake_access_token_store.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/fake_access_token_store.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M content/browser/geolocation/geolocation_provider_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/geolocation/geolocation_provider_impl_unittest.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M content/browser/geolocation/location_api_adapter_android.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/geolocation/location_api_adapter_android.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M content/browser/geolocation/mock_location_provider.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/geolocation/mock_location_provider.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M content/browser/geolocation/network_location_provider.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_common.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 7 chunks +10 lines, -7 lines 0 comments Download
M content/browser/histogram_synchronizer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 5 chunks +8 lines, -13 lines 0 comments Download
M content/browser/indexed_db/indexed_db_quota_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_quota_client_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 4 chunks +17 lines, -21 lines 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M content/browser/loader/upload_data_stream_builder_unittest.cc View 11 chunks +21 lines, -36 lines 0 comments Download
M content/browser/media/capture/content_video_capture_device_core.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/capture/web_contents_audio_input_stream_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/media/media_internals_proxy.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/net/view_http_cache_job_factory.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/notifications/platform_notification_context_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/plugin_loader_posix.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/plugin_loader_posix.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M content/browser/plugin_service_impl.h View 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 2 3 4 chunks +20 lines, -22 lines 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M content/browser/power_profiler/power_profiler_service_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/power_save_blocker_x11.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/quota/mock_quota_manager.cc View 3 chunks +8 lines, -12 lines 0 comments Download
M content/browser/quota/mock_quota_manager_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/quota/quota_backend_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/quota/quota_manager_unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M content/browser/quota/quota_reservation_manager_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/quota/quota_temporary_storage_evictor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/quota/storage_monitor_unittest.cc View 3 chunks +9 lines, -15 lines 0 comments Download
M content/browser/quota/usage_tracker_unittest.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 9 chunks +14 lines, -13 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 3 chunks +10 lines, -16 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 9 chunks +21 lines, -23 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper/quota_reservation_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 7 chunks +17 lines, -21 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 5 chunks +17 lines, -16 lines 0 comments Download
M content/browser/renderer_host/websocket_host.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/shareable_file_reference_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/speech/speech_recognition_browsertest.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M content/browser/speech/speech_recognition_manager_impl.cc View 6 chunks +17 lines, -26 lines 0 comments Download
M content/browser/speech/speech_recognizer_impl_unittest.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/storage_partition_impl_unittest.cc View 18 chunks +44 lines, -51 lines 0 comments Download
M content/browser/streams/stream.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M content/browser/streams/stream_handle_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/streams/stream_handle_impl.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/streams/stream_url_request_job.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 5 chunks +12 lines, -14 lines 0 comments Download
M content/public/browser/browser_thread.h View 4 chunks +8 lines, -8 lines 0 comments Download
M content/public/browser/devtools_agent_host.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/public/renderer/render_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/browser_test_base.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/test/fake_speech_recognition_manager.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/public/test/frame_load_waiter.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/public/test/mock_blob_url_request_context.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/test/mock_storage_client.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M content/public/test/render_view_test.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/public/test/sandbox_file_system_test_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/test_file_system_context.cc View 5 chunks +14 lines, -20 lines 0 comments Download
M content/public/test/test_utils.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M content/shell/browser/blink_test_controller.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_main.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M content/shell/browser/shell.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/test_video_frame_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/test_video_frame_provider.cc View 4 chunks +12 lines, -13 lines 0 comments Download
M content/test/content_browser_test_test.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/test/fake_compositor_dependencies.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/test/net/url_request_abort_on_end_job.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/utility/in_process_utility_thread.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/utility/webthread_impl_for_utility_thread.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 31 (13 generated)
Sami
I originally started doing this just for content/browser/, but turns out there were only a ...
5 years, 6 months ago (2015-06-01 19:20:53 UTC) #2
no sievers
lgtm https://codereview.chromium.org/1159623009/diff/1/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/1159623009/diff/1/content/browser/browser_main_loop.cc#newcode715 content/browser/browser_main_loop.cc:715: base::MessageLoop::current()->task_runner())); Should this also be base::ThreadTaskRunnerHandle::Get()? Also you ...
5 years, 6 months ago (2015-06-01 23:30:47 UTC) #3
Sami
Thanks Daniel! https://codereview.chromium.org/1159623009/diff/1/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/1159623009/diff/1/content/browser/browser_main_loop.cc#newcode715 content/browser/browser_main_loop.cc:715: base::MessageLoop::current()->task_runner())); On 2015/06/01 23:30:47, sievers wrote: > ...
5 years, 6 months ago (2015-06-03 14:55:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623009/20001
5 years, 6 months ago (2015-06-03 14:57:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/78152)
5 years, 6 months ago (2015-06-03 15:33:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623009/40001
5 years, 6 months ago (2015-06-03 17:58:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/16686)
5 years, 6 months ago (2015-06-03 18:25:52 UTC) #15
ncarter (slow)
[reviewers -= ncarter] sievers's review is good enough for me
5 years, 6 months ago (2015-06-03 19:37:03 UTC) #16
ncarter (slow)
[reviewers -= ncarter] sievers's review is good enough for me
5 years, 6 months ago (2015-06-03 19:37:29 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623009/80001
5 years, 6 months ago (2015-06-05 14:12:18 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 6 months ago (2015-06-05 14:20:34 UTC) #22
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/5d18b2493af36d77d3c491854e3d56f46f5f747c Cr-Commit-Position: refs/heads/master@{#333043}
5 years, 6 months ago (2015-06-05 14:21:45 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623009/80001
5 years, 6 months ago (2015-06-05 17:15:47 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 6 months ago (2015-06-05 17:24:14 UTC) #26
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/422456f9d53f0bf936a64f21a1463fd0abd3df84 Cr-Commit-Position: refs/heads/master@{#333081}
5 years, 6 months ago (2015-06-05 17:25:13 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623009/80001
5 years, 6 months ago (2015-06-05 19:42:46 UTC) #29
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 6 months ago (2015-06-05 19:53:21 UTC) #30
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:00:30 UTC) #31
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/95082a6a47108c4e20a77cc224172a293065ab05
Cr-Commit-Position: refs/heads/master@{#333112}

Powered by Google App Engine
This is Rietveld 408576698