Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Side by Side Diff: content/browser/shareable_file_reference_unittest.cc

Issue 1159623009: content: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test build fix. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "storage/browser/blob/shareable_file_reference.h" 5 #include "storage/browser/blob/shareable_file_reference.h"
6 6
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/message_loop/message_loop_proxy.h"
10 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/single_thread_task_runner.h"
11 #include "base/thread_task_runner_handle.h"
11 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
12 13
13 using storage::ShareableFileReference; 14 using storage::ShareableFileReference;
14 15
15 namespace content { 16 namespace content {
16 17
17 TEST(ShareableFileReferenceTest, TestReferences) { 18 TEST(ShareableFileReferenceTest, TestReferences) {
18 base::MessageLoop message_loop; 19 base::MessageLoop message_loop;
19 scoped_refptr<base::MessageLoopProxy> loop_proxy = 20 scoped_refptr<base::SingleThreadTaskRunner> task_runner =
20 base::MessageLoopProxy::current(); 21 base::ThreadTaskRunnerHandle::Get();
21 base::ScopedTempDir temp_dir; 22 base::ScopedTempDir temp_dir;
22 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 23 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
23 24
24 // Create a file. 25 // Create a file.
25 base::FilePath file; 26 base::FilePath file;
26 base::CreateTemporaryFileInDir(temp_dir.path(), &file); 27 base::CreateTemporaryFileInDir(temp_dir.path(), &file);
27 EXPECT_TRUE(base::PathExists(file)); 28 EXPECT_TRUE(base::PathExists(file));
28 29
29 // Create a first reference to that file. 30 // Create a first reference to that file.
30 scoped_refptr<ShareableFileReference> reference1; 31 scoped_refptr<ShareableFileReference> reference1;
31 reference1 = ShareableFileReference::Get(file); 32 reference1 = ShareableFileReference::Get(file);
32 EXPECT_FALSE(reference1.get()); 33 EXPECT_FALSE(reference1.get());
33 reference1 = ShareableFileReference::GetOrCreate( 34 reference1 = ShareableFileReference::GetOrCreate(
34 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, loop_proxy.get()); 35 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, task_runner.get());
35 EXPECT_TRUE(reference1.get()); 36 EXPECT_TRUE(reference1.get());
36 EXPECT_TRUE(file == reference1->path()); 37 EXPECT_TRUE(file == reference1->path());
37 38
38 // Get a second reference to that file. 39 // Get a second reference to that file.
39 scoped_refptr<ShareableFileReference> reference2; 40 scoped_refptr<ShareableFileReference> reference2;
40 reference2 = ShareableFileReference::Get(file); 41 reference2 = ShareableFileReference::Get(file);
41 EXPECT_EQ(reference1.get(), reference2.get()); 42 EXPECT_EQ(reference1.get(), reference2.get());
42 reference2 = ShareableFileReference::GetOrCreate( 43 reference2 = ShareableFileReference::GetOrCreate(
43 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, loop_proxy.get()); 44 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, task_runner.get());
44 EXPECT_EQ(reference1.get(), reference2.get()); 45 EXPECT_EQ(reference1.get(), reference2.get());
45 46
46 // Drop the first reference, the file and reference should still be there. 47 // Drop the first reference, the file and reference should still be there.
47 reference1 = NULL; 48 reference1 = NULL;
48 EXPECT_TRUE(ShareableFileReference::Get(file).get()); 49 EXPECT_TRUE(ShareableFileReference::Get(file).get());
49 base::RunLoop().RunUntilIdle(); 50 base::RunLoop().RunUntilIdle();
50 EXPECT_TRUE(base::PathExists(file)); 51 EXPECT_TRUE(base::PathExists(file));
51 52
52 // Drop the second reference, the file and reference should get deleted. 53 // Drop the second reference, the file and reference should get deleted.
53 reference2 = NULL; 54 reference2 = NULL;
54 EXPECT_FALSE(ShareableFileReference::Get(file).get()); 55 EXPECT_FALSE(ShareableFileReference::Get(file).get());
55 base::RunLoop().RunUntilIdle(); 56 base::RunLoop().RunUntilIdle();
56 EXPECT_FALSE(base::PathExists(file)); 57 EXPECT_FALSE(base::PathExists(file));
57 58
58 // TODO(michaeln): add a test for files that aren't deletable behavior. 59 // TODO(michaeln): add a test for files that aren't deletable behavior.
59 } 60 }
60 61
61 } // namespace content 62 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698