Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: content/browser/dom_storage/dom_storage_task_runner.h

Issue 1159623009: content: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test build fix. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_H_ 5 #ifndef CONTENT_BROWSER_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_H_
6 #define CONTENT_BROWSER_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_H_ 6 #define CONTENT_BROWSER_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/sequenced_task_runner.h" 9 #include "base/sequenced_task_runner.h"
10 #include "base/single_thread_task_runner.h"
10 #include "base/threading/sequenced_worker_pool.h" 11 #include "base/threading/sequenced_worker_pool.h"
11 #include "base/time/time.h" 12 #include "base/time/time.h"
12 #include "content/common/content_export.h" 13 #include "content/common/content_export.h"
13 14
14 namespace base { 15 namespace base {
15 class MessageLoopProxy; 16 class SingleThreadTaskRunner;
16 } 17 }
17 18
18 namespace content { 19 namespace content {
19 20
20 // DOMStorage uses two task sequences (primary vs commit) to avoid 21 // DOMStorage uses two task sequences (primary vs commit) to avoid
21 // primary access from queuing up behind commits to disk. 22 // primary access from queuing up behind commits to disk.
22 // * Initialization, shutdown, and administrative tasks are performed as 23 // * Initialization, shutdown, and administrative tasks are performed as
23 // shutdown-blocking primary sequence tasks. 24 // shutdown-blocking primary sequence tasks.
24 // * Tasks directly related to the javascript'able interface are performed 25 // * Tasks directly related to the javascript'able interface are performed
25 // as shutdown-blocking primary sequence tasks. 26 // as shutdown-blocking primary sequence tasks.
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 // A derived class used in chromium that utilizes a SequenceWorkerPool 67 // A derived class used in chromium that utilizes a SequenceWorkerPool
67 // under dom_storage specific SequenceTokens. The |delayed_task_loop| 68 // under dom_storage specific SequenceTokens. The |delayed_task_loop|
68 // is used to delay scheduling on the worker pool. 69 // is used to delay scheduling on the worker pool.
69 class CONTENT_EXPORT DOMStorageWorkerPoolTaskRunner : 70 class CONTENT_EXPORT DOMStorageWorkerPoolTaskRunner :
70 public DOMStorageTaskRunner { 71 public DOMStorageTaskRunner {
71 public: 72 public:
72 DOMStorageWorkerPoolTaskRunner( 73 DOMStorageWorkerPoolTaskRunner(
73 base::SequencedWorkerPool* sequenced_worker_pool, 74 base::SequencedWorkerPool* sequenced_worker_pool,
74 base::SequencedWorkerPool::SequenceToken primary_sequence_token, 75 base::SequencedWorkerPool::SequenceToken primary_sequence_token,
75 base::SequencedWorkerPool::SequenceToken commit_sequence_token, 76 base::SequencedWorkerPool::SequenceToken commit_sequence_token,
76 base::MessageLoopProxy* delayed_task_loop); 77 base::SingleThreadTaskRunner* delayed_task_task_runner);
77 78
78 bool PostDelayedTask(const tracked_objects::Location& from_here, 79 bool PostDelayedTask(const tracked_objects::Location& from_here,
79 const base::Closure& task, 80 const base::Closure& task,
80 base::TimeDelta delay) override; 81 base::TimeDelta delay) override;
81 82
82 bool PostShutdownBlockingTask(const tracked_objects::Location& from_here, 83 bool PostShutdownBlockingTask(const tracked_objects::Location& from_here,
83 SequenceID sequence_id, 84 SequenceID sequence_id,
84 const base::Closure& task) override; 85 const base::Closure& task) override;
85 86
86 bool IsRunningOnSequence(SequenceID sequence_id) const override; 87 bool IsRunningOnSequence(SequenceID sequence_id) const override;
87 88
88 protected: 89 protected:
89 ~DOMStorageWorkerPoolTaskRunner() override; 90 ~DOMStorageWorkerPoolTaskRunner() override;
90 91
91 private: 92 private:
92 93
93 base::SequencedWorkerPool::SequenceToken IDtoToken(SequenceID id) const; 94 base::SequencedWorkerPool::SequenceToken IDtoToken(SequenceID id) const;
94 95
95 const scoped_refptr<base::MessageLoopProxy> message_loop_; 96 const scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
96 const scoped_refptr<base::SequencedWorkerPool> sequenced_worker_pool_; 97 const scoped_refptr<base::SequencedWorkerPool> sequenced_worker_pool_;
97 base::SequencedWorkerPool::SequenceToken primary_sequence_token_; 98 base::SequencedWorkerPool::SequenceToken primary_sequence_token_;
98 base::SequencedWorkerPool::SequenceToken commit_sequence_token_; 99 base::SequencedWorkerPool::SequenceToken commit_sequence_token_;
99 }; 100 };
100 101
101 // A derived class used in unit tests that ignores all delays so 102 // A derived class used in unit tests that ignores all delays so
102 // we don't block in unit tests waiting for timeouts to expire. 103 // we don't block in unit tests waiting for timeouts to expire.
103 // There is no distinction between [non]-shutdown-blocking or 104 // There is no distinction between [non]-shutdown-blocking or
104 // the primary sequence vs the commit sequence in the mock, 105 // the primary sequence vs the commit sequence in the mock,
105 // all tasks are scheduled on |message_loop| with zero delay. 106 // all tasks are scheduled on |message_loop| with zero delay.
106 class CONTENT_EXPORT MockDOMStorageTaskRunner : 107 class CONTENT_EXPORT MockDOMStorageTaskRunner :
107 public DOMStorageTaskRunner { 108 public DOMStorageTaskRunner {
108 public: 109 public:
109 explicit MockDOMStorageTaskRunner(base::MessageLoopProxy* message_loop); 110 explicit MockDOMStorageTaskRunner(base::SingleThreadTaskRunner* task_runner);
110 111
111 bool PostDelayedTask(const tracked_objects::Location& from_here, 112 bool PostDelayedTask(const tracked_objects::Location& from_here,
112 const base::Closure& task, 113 const base::Closure& task,
113 base::TimeDelta delay) override; 114 base::TimeDelta delay) override;
114 115
115 bool PostShutdownBlockingTask(const tracked_objects::Location& from_here, 116 bool PostShutdownBlockingTask(const tracked_objects::Location& from_here,
116 SequenceID sequence_id, 117 SequenceID sequence_id,
117 const base::Closure& task) override; 118 const base::Closure& task) override;
118 119
119 bool IsRunningOnSequence(SequenceID sequence_id) const override; 120 bool IsRunningOnSequence(SequenceID sequence_id) const override;
120 121
121 protected: 122 protected:
122 ~MockDOMStorageTaskRunner() override; 123 ~MockDOMStorageTaskRunner() override;
123 124
124 private: 125 private:
125 const scoped_refptr<base::MessageLoopProxy> message_loop_; 126 const scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
126 }; 127 };
127 128
128 } // namespace content 129 } // namespace content
129 130
130 #endif // CONTENT_BROWSER_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_H_ 131 #endif // CONTENT_BROWSER_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_H_
OLDNEW
« no previous file with comments | « content/browser/dom_storage/dom_storage_context_wrapper.cc ('k') | content/browser/dom_storage/dom_storage_task_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698