Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1158813004: Style guide says enum values should be lowerCamelCase. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
jackson
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, abarth-chromium
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -73 lines) Patch
M sky/examples/raw/interactive_flex.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/examples/raw/render_paragraph.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_app.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M sky/examples/stocks2/lib/stock_arrow.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/checkbox.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/drawer_header.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/ink_well.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/input.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/menu_item.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/popup_menu.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M sky/sdk/lib/framework/components2/scaffold.dart View 6 chunks +27 lines, -27 lines 0 comments Download
M sky/sdk/lib/framework/components2/tool_bar.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/fn.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M sky/sdk/lib/framework/layout.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/rendering/flex.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M sky/tests/raw/render_flex.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
jackson
lgtm
5 years, 6 months ago (2015-06-04 19:16:51 UTC) #2
Hixie
5 years, 6 months ago (2015-06-04 19:24:14 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
cd99017b3fe59aa09d7f066e2358e534428ac407 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698