sky/sdk/lib/framework/layout.dart - Issue 1158813004: Style guide says enum values should be lowerCamelCase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/layout.dart

Issue 1158813004: Style guide says enum values should be lowerCamelCase. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/framework/layout.dart

diff --git a/sky/sdk/lib/framework/layout.dart b/sky/sdk/lib/framework/layout.dart

index 2ade1e9709024e8dafca300c04ef5369edfdc686..9020c7a18b912dc022053010cb3a0d6f8d60ef87 100644

--- a/sky/sdk/lib/framework/layout.dart

+++ b/sky/sdk/lib/framework/layout.dart

@@ -377,8 +377,8 @@ class RenderCSSFlex extends RenderCSSContainer {

String stylesToClasses(List<Style> styles) {

var settings = _displayFlex._className;

switch (_direction) {

- case FlexDirection.Row: settings += ' ' + _displayFlexRow._className; break;

- case FlexDirection.Column: settings += ' ' + _displayFlexColumn._className; break;

+ case FlexDirection.horizontal: settings += ' ' + _displayFlexRow._className; break;

+ case FlexDirection.vertical: settings += ' ' + _displayFlexColumn._className; break;

}

return super.stylesToClasses(styles) + ' ' + settings;

}

« no previous file with comments | « sky/sdk/lib/framework/fn2.dart ('k') | sky/sdk/lib/framework/rendering/flex.dart » ('j') | no next file with comments »