Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: sky/sdk/lib/framework/fn2.dart

Issue 1158813004: Style guide says enum values should be lowerCamelCase. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/fn.dart ('k') | sky/sdk/lib/framework/layout.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/fn2.dart
diff --git a/sky/sdk/lib/framework/fn2.dart b/sky/sdk/lib/framework/fn2.dart
index 64b8da68a553320b4c3a614a74d8d8f78928fb64..03206def57d7e72da18643c90c4344a0f380d933 100644
--- a/sky/sdk/lib/framework/fn2.dart
+++ b/sky/sdk/lib/framework/fn2.dart
@@ -23,7 +23,7 @@ import 'rendering/stack.dart';
final bool _shouldLogRenderDuration = false;
final bool _shouldTrace = false;
-enum _SyncOperation { IDENTICAL, INSERTION, STATEFUL, STATELESS, REMOVAL }
+enum _SyncOperation { identical, insertion, stateful, stateless, removal }
/*
* All Effen nodes derive from UINode. All nodes have a _parent, a _key and
@@ -95,14 +95,14 @@ abstract class UINode {
}
void removeChild(UINode node) {
- _traceSync(_SyncOperation.REMOVAL, node._key);
+ _traceSync(_SyncOperation.removal, node._key);
node._remove();
}
// Returns the child which should be retained as the child of this node.
UINode syncChild(UINode node, UINode oldNode, dynamic slot) {
if (node == oldNode) {
- _traceSync(_SyncOperation.IDENTICAL, node == null ? '*null*' : node._key);
+ _traceSync(_SyncOperation.identical, node == null ? '*null*' : node._key);
return node; // Nothing to do. Subtrees must be identical.
}
@@ -121,7 +121,7 @@ abstract class UINode {
}
if (node._willSync(oldNode)) {
- _traceSync(_SyncOperation.STATEFUL, node._key);
+ _traceSync(_SyncOperation.stateful, node._key);
oldNode._sync(node, slot);
node._defunct = true;
assert(oldNode.root is RenderObject);
@@ -132,9 +132,9 @@ abstract class UINode {
node._parent = this;
if (oldNode == null) {
- _traceSync(_SyncOperation.INSERTION, node._key);
+ _traceSync(_SyncOperation.insertion, node._key);
} else {
- _traceSync(_SyncOperation.STATELESS, node._key);
+ _traceSync(_SyncOperation.stateless, node._key);
}
node._sync(oldNode, slot);
if (oldNode != null)
@@ -638,7 +638,7 @@ class FlexContainer extends MultiChildRenderObjectWrapper {
FlexContainer({
Object key,
List<UINode> children,
- this.direction: FlexDirection.Horizontal
+ this.direction: FlexDirection.horizontal
}) : super(key: key, children: children);
void syncRenderObject(UINode old) {
« no previous file with comments | « sky/sdk/lib/framework/fn.dart ('k') | sky/sdk/lib/framework/layout.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698