Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Side by Side Diff: Source/core/html/HTMLMediaElement.cpp

Issue 1157253010: Remove WebMediaPlayerClient::requestFullscreen() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLMediaElement.h ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 2760 matching lines...) Expand 10 before | Expand all | Expand 10 after
2771 2771
2772 if (!webMediaPlayer()) 2772 if (!webMediaPlayer())
2773 return; 2773 return;
2774 2774
2775 if (webMediaPlayer()->paused()) 2775 if (webMediaPlayer()->paused())
2776 pause(); 2776 pause();
2777 else 2777 else
2778 playInternal(); 2778 playInternal();
2779 } 2779 }
2780 2780
2781 void HTMLMediaElement::mediaPlayerRequestFullscreen()
2782 {
2783 WTF_LOG(Media, "HTMLMediaElement::mediaPlayerRequestFullscreen(%p)", this);
2784
2785 // The player is responsible for only invoking this callback in response to
2786 // user interaction or when it is technically required to play the video.
2787 UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture);
2788
2789 enterFullscreen();
2790 }
2791
2792 void HTMLMediaElement::mediaPlayerRequestSeek(double time) 2781 void HTMLMediaElement::mediaPlayerRequestSeek(double time)
2793 { 2782 {
2794 // The player is the source of this seek request. 2783 // The player is the source of this seek request.
2795 if (m_mediaController) { 2784 if (m_mediaController) {
2796 m_mediaController->setCurrentTime(time); 2785 m_mediaController->setCurrentTime(time);
2797 return; 2786 return;
2798 } 2787 }
2799 setCurrentTime(time, ASSERT_NO_EXCEPTION); 2788 setCurrentTime(time, ASSERT_NO_EXCEPTION);
2800 } 2789 }
2801 2790
(...skipping 876 matching lines...) Expand 10 before | Expand all | Expand 10 after
3678 3667
3679 #if ENABLE(WEB_AUDIO) 3668 #if ENABLE(WEB_AUDIO)
3680 void HTMLMediaElement::clearWeakMembers(Visitor* visitor) 3669 void HTMLMediaElement::clearWeakMembers(Visitor* visitor)
3681 { 3670 {
3682 if (!Heap::isHeapObjectAlive(m_audioSourceNode) && audioSourceProvider()) 3671 if (!Heap::isHeapObjectAlive(m_audioSourceNode) && audioSourceProvider())
3683 audioSourceProvider()->setClient(nullptr); 3672 audioSourceProvider()->setClient(nullptr);
3684 } 3673 }
3685 #endif 3674 #endif
3686 3675
3687 } 3676 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLMediaElement.h ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698