Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1157163003: Remove ProxyResolver::(Cancel)SetPacScript and LegacyProxyResolverFactory. (Closed)

Created:
5 years, 7 months ago by Sam McNally
Modified:
5 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@v8-proxy-resolver-refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ProxyResolver::(Cancel)SetPacScript and LegacyProxyResolverFactory. BUG=467403 Committed: https://crrev.com/e90c921f3fed1a7dc9c4dd3b86a47b399524a3c3 Cr-Commit-Position: refs/heads/master@{#331693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -601 lines) Patch
M net/http/http_network_transaction_unittest.cc View 2 chunks +1 line, -8 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/proxy/mock_proxy_resolver.h View 5 chunks +5 lines, -56 lines 0 comments Download
M net/proxy/mock_proxy_resolver.cc View 5 chunks +21 lines, -71 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/mojo_proxy_resolver_impl_unittest.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M net/proxy/multi_threaded_proxy_resolver.cc View 3 chunks +1 line, -16 lines 0 comments Download
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 2 chunks +1 line, -10 lines 0 comments Download
M net/proxy/proxy_resolver.h View 2 chunks +1 line, -20 lines 0 comments Download
M net/proxy/proxy_resolver_factory.h View 1 chunk +0 lines, -22 lines 0 comments Download
M net/proxy/proxy_resolver_factory.cc View 2 chunks +0 lines, -103 lines 0 comments Download
D net/proxy/proxy_resolver_factory_unittest.cc View 1 chunk +0 lines, -175 lines 0 comments Download
M net/proxy/proxy_resolver_mac.cc View 2 chunks +1 line, -17 lines 0 comments Download
M net/proxy/proxy_resolver_mojo.cc View 3 chunks +1 line, -16 lines 0 comments Download
M net/proxy/proxy_resolver_perftest.cc View 2 chunks +1 line, -11 lines 0 comments Download
M net/proxy/proxy_resolver_v8_tracing.cc View 3 chunks +1 line, -16 lines 0 comments Download
M net/proxy/proxy_resolver_winhttp.cc View 3 chunks +1 line, -18 lines 0 comments Download
M net/proxy/proxy_service.cc View 4 chunks +2 lines, -17 lines 0 comments Download
M net/proxy/proxy_service_unittest.cc View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam McNally
5 years, 7 months ago (2015-05-27 04:25:56 UTC) #2
eroman
LGTM, great cleanup!
5 years, 7 months ago (2015-05-27 18:32:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157163003/1
5 years, 6 months ago (2015-05-27 23:38:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-27 23:43:56 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-05-27 23:44:50 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e90c921f3fed1a7dc9c4dd3b86a47b399524a3c3
Cr-Commit-Position: refs/heads/master@{#331693}

Powered by Google App Engine
This is Rietveld 408576698