Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: net/proxy/proxy_resolver_winhttp.cc

Issue 1157163003: Remove ProxyResolver::(Cancel)SetPacScript and LegacyProxyResolverFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-proxy-resolver-refactor
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_resolver_v8_tracing.cc ('k') | net/proxy/proxy_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver_winhttp.cc
diff --git a/net/proxy/proxy_resolver_winhttp.cc b/net/proxy/proxy_resolver_winhttp.cc
index f7193d16a5f2ec4865caa8d934820a42742007e6..193fd988118cae3fbb8920a100a7250fb8c58e2a 100644
--- a/net/proxy/proxy_resolver_winhttp.cc
+++ b/net/proxy/proxy_resolver_winhttp.cc
@@ -46,11 +46,6 @@ class ProxyResolverWinHttp : public ProxyResolver {
LoadState GetLoadState(RequestHandle request) const override;
- void CancelSetPacScript() override;
-
- int SetPacScript(const scoped_refptr<ProxyResolverScriptData>& script_data,
- const CompletionCallback& /*callback*/) override;
-
private:
bool OpenWinHttpSession();
void CloseWinHttpSession();
@@ -65,8 +60,7 @@ class ProxyResolverWinHttp : public ProxyResolver {
ProxyResolverWinHttp::ProxyResolverWinHttp(
const scoped_refptr<ProxyResolverScriptData>& script_data)
- : ProxyResolver(false /*expects_pac_bytes*/),
- session_handle_(NULL),
+ : session_handle_(NULL),
pac_url_(script_data->type() == ProxyResolverScriptData::TYPE_AUTO_DETECT
? GURL("http://wpad/wpad.dat")
: script_data->url()) {
@@ -169,17 +163,6 @@ LoadState ProxyResolverWinHttp::GetLoadState(RequestHandle request) const {
return LOAD_STATE_IDLE;
}
-void ProxyResolverWinHttp::CancelSetPacScript() {
- NOTREACHED();
-}
-
-int ProxyResolverWinHttp::SetPacScript(
- const scoped_refptr<ProxyResolverScriptData>& script_data,
- const CompletionCallback& /*callback*/) {
- NOTREACHED();
- return ERR_NOT_IMPLEMENTED;
-}
-
bool ProxyResolverWinHttp::OpenWinHttpSession() {
DCHECK(!session_handle_);
session_handle_ = WinHttpOpen(NULL,
« no previous file with comments | « net/proxy/proxy_resolver_v8_tracing.cc ('k') | net/proxy/proxy_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698